Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Add option to append for BigQuery Write #42584

Merged
merged 6 commits into from
Jan 24, 2024

Conversation

matthew29tang
Copy link
Contributor

Why are these changes needed?

Add option to append for BigQuery write instead of automatically overwriting the table (if it already exists).

Related issue number

Closes #42240

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Tang <tangmatthew@google.com>
Signed-off-by: Matthew Tang <tangmatthew@google.com>
Copy link
Member

@bveeramani bveeramani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Since we're not adding unit tests, have you gotten a chance to test this manually?

python/ray/data/dataset.py Show resolved Hide resolved
python/ray/data/datasource/bigquery_datasink.py Outdated Show resolved Hide resolved
python/ray/data/datasource/bigquery_datasink.py Outdated Show resolved Hide resolved
@matthew29tang
Copy link
Contributor Author

Thanks for the review! I tested it on a local cluster doing writes with no overwrite_table kwarg specified, overwrite_table=True, and overwrite_table=False. I verified that it correctly appended/overwrote from the BigQuery console.

@bveeramani bveeramani merged commit 9e6f5c8 into ray-project:master Jan 24, 2024
9 checks passed
khluu pushed a commit to khluu/ray that referenced this pull request Jan 24, 2024
Add option to append for BigQuery write instead of automatically overwriting the table (if it already exists).

---------

Signed-off-by: Matthew Tang <tangmatthew@google.com>
Signed-off-by: khluu <khluu000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Data] Add append option to write_bigquery
2 participants