-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ray dashboard] Add resource utilization columns to actors #42633
Merged
architkulkarni
merged 15 commits into
ray-project:master
from
nikitavemuri:nikita/actor_resource_utilization
Jan 24, 2024
Merged
[ray dashboard] Add resource utilization columns to actors #42633
architkulkarni
merged 15 commits into
ray-project:master
from
nikitavemuri:nikita/actor_resource_utilization
Jan 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
nikitavemuri
force-pushed
the
nikita/actor_resource_utilization
branch
from
January 24, 2024 01:35
b60c76e
to
1cadd93
Compare
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
…ita/actor_resource_utilization
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Given the number of columns, let's move it before the "Restarted" column. I think that orders it relatively more in order of importance. |
alanwguo
approved these changes
Jan 24, 2024
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
CPU
,Memory
,GPU
,GRAM
) to actors table page. This is similar to the corresponding columns on the cluster table page and allows users to better track resource utilization of actors. I will add column sort as a future PR./logical/actors
API to return necessary resource utilization values. These values are already returned by/logical/actors/{actor_id}
./logical/actors/{actor_id}
already fetches data for all actors and then filters by actor id, so with this change the performance of/logical/actors
shouldn't be worse than/logical/actors/{actor_id}
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.