Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ray dashboard] Add resource utilization columns to actors #42633

Merged

Conversation

nikitavemuri
Copy link
Contributor

@nikitavemuri nikitavemuri commented Jan 24, 2024

Why are these changes needed?

  • Add resource utilization columns (CPU, Memory, GPU, GRAM) to actors table page. This is similar to the corresponding columns on the cluster table page and allows users to better track resource utilization of actors. I will add column sort as a future PR.
  • Actor table in node detail page will also contain these additional columns
  • Update /logical/actors API to return necessary resource utilization values. These values are already returned by /logical/actors/{actor_id}.
    • Note about performance: /logical/actors/{actor_id} already fetches data for all actors and then filters by actor id, so with this change the performance of /logical/actors shouldn't be worse than /logical/actors/{actor_id}
Screen Shot 2024-01-23 at 5 51 14 PM

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Nikita Vemuri added 9 commits January 23, 2024 15:40
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri force-pushed the nikita/actor_resource_utilization branch from b60c76e to 1cadd93 Compare January 24, 2024 01:35
Nikita Vemuri added 3 commits January 23, 2024 17:41
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@nikitavemuri nikitavemuri marked this pull request as ready for review January 24, 2024 01:51
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@alanwguo
Copy link
Contributor

Given the number of columns, let's move it before the "Restarted" column. I think that orders it relatively more in order of importance.

Nikita Vemuri added 2 commits January 24, 2024 10:27
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
Signed-off-by: Nikita Vemuri <nikitavemuri@anyscale.com>
@architkulkarni architkulkarni merged commit b383c12 into ray-project:master Jan 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants