[Serve] Document max_replicas_per_node deployment option #42743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
requested review from
edoakes,
shrekris-anyscale,
sihanwang41,
zcin,
architkulkarni and
a team
as code owners
edoakes
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Please add:
- A description of what the default scheduling policy is and why it might be problematic.
- Make it clear that the behavior is only within a deployment and multiple deployments can still share resources.
- A concrete code example of an application where this is set. Maybe let it have 2 deployments and set
max_replicas_per_node=1on one,max_replicas_per_node=2on the other. Then describe how these would be scheduled.
zcin
reviewed
Jan 30, 2024
omatthew98
pushed a commit
to omatthew98/ray
that referenced
this pull request
Jan 31, 2024
…#42743) * Document max_replicas_per_node deployment option --------- Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add documentation for
max_replicas_per_nodedeployment optionRelated issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.