Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release][tune] Remove deprecated SyncConfig usage in tune_cloud_durable release test #43029

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

justinvyu
Copy link
Contributor

Why are these changes needed?

#42909 hard deprecated outdated SyncConfig parameters, and this release test was not updated along with the rest of the examples. This syncer parameter was already being ignored, so it's okay to remove it fully now.

Related issue number

Closes #43008

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
@justinvyu justinvyu merged commit ccfcb21 into ray-project:master Feb 7, 2024
9 checks passed
@justinvyu justinvyu deleted the fix_cloud_release_test branch February 7, 2024 02:13
tterrysun pushed a commit to tterrysun/ray that referenced this pull request Feb 14, 2024
…urable` release test (ray-project#43029)

ray-project#42909 hard deprecated outdated `SyncConfig` parameters, and this release test was not updated along with the rest of the examples. This `syncer` parameter was already being ignored, so it's okay to remove it fully now.

Signed-off-by: Justin Yu <justinvyu@anyscale.com>
Signed-off-by: tterrysun <terry@anyscale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release test tune_cloud_durable_upload.aws failed
2 participants