[RLlib] Issue 42396: Fix Algorithm.training_step() default implementation (multi-agent ALL_MODULES key causing error). #43316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla and
kouroshHakha
as code owners
garymm
reviewed
Feb 21, 2024
| self.workers.sync_weights( | ||
| from_worker_or_learner_group=from_worker_or_trainer, | ||
| policies=list(train_results.keys()), | ||
| policies=set(train_results.keys()) - {ALL_MODULES}, |
There was a problem hiding this comment.
Great catch @sven1977 !
simonsays1980
approved these changes
Feb 21, 2024
| self.workers.sync_weights( | ||
| from_worker_or_learner_group=from_worker_or_trainer, | ||
| policies=list(train_results.keys()), | ||
| policies=set(train_results.keys()) - {ALL_MODULES}, |
There was a problem hiding this comment.
Great catch @sven1977 !
kouroshHakha
approved these changes
Feb 21, 2024
sven1977
deleted the
issue_42396_fix_algo_default_training_step_method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 42396: Fix Algorithm.training_step() default implementation (multi-agent ALL_MODULES key causing error).
Why are these changes needed?
Closes #42396
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.