[RLlib] ConnectorV2: Fix bug in AddColumnsFromEpisodesToTrainBatch class (multi-agent related).
#43680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sven1977
requested review from
avnishn,
ArturNiederfahrenhorst,
maxpumperla,
kouroshHakha and
simonsays1980
as code owners
…atch_connector' into fix_bug_in_add_column_to_train_batch_connector
…ctor Signed-off-by: Sven Mika <svenmika1977@gmail.com>
sven1977
added
the
tests-ok
simonsays1980
approved these changes
Mar 5, 2024
| agents_that_stepped_only=False, | ||
| ): | ||
| for column in sa_episode.extra_model_outputs.keys(): | ||
| if column not in skip_columns: |
There was a problem hiding this comment.
Great! That should leave all custom columns untouched now.
| @@ -1706,12 +1706,3 @@ def _set_optimizer_lr(optimizer: Optimizer, lr: float) -> None: | |||
| @abc.abstractmethod | |||
| def _get_clip_function() -> Callable: | |||
| """Returns the gradient clipping function to use, given the framework.""" | |||
|
|
|||
There was a problem hiding this comment.
Haha yes, hps has now gone to the dark side :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ConnectorV2: Fix bug in
AddColumnsFromEpisodesToTrainBatchclass (multi-agent related).The bug would appear only in multi-agent AND if one RLModule does NOT produce action_dist_inputs (b/c e.g. it's a random one). It was caused by using a (random) single agent episode as a reference episode to figure out, which extra_model_output columns to loop through. If this reference single agent episode was from the random RLModule, the column
action_dist_inputs(and others) would be missing.Why are these changes needed?
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/under thecorresponding
.rstfile.