Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix get_gpu_ids to return a list of str when CUDA_VISIBLE_DEVICES is set #43714

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented Mar 5, 2024

Why are these changes needed?

#40286 accidentally changed ray.get_gpu_ids() to always return a list of int while it should return a list of str when CUDA_VISIBLE_DEVICES is set before starting ray.

This PR reverts back to the original behavior.

Related issue number

Closes #43314

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@fishbone fishbone merged commit cf0681b into ray-project:master Mar 5, 2024
9 checks passed
@jjyao jjyao deleted the jjyao/int branch March 5, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Core] ray.get_gpu_ids fails when CUDA_VISIBLE_DEVICES uses GPU UUIDs
2 participants