Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] remove scikit-optimize search algorithm #43969

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

matthewdeng
Copy link
Contributor

@matthewdeng matthewdeng commented Mar 13, 2024

Why are these changes needed?

Removing SkOptSearch as there is little usage, and the scikit-optimize library has not been maintained.

  1. The last commit is from 3 years ago.
  2. The latest stable release does not support Python 3.11.
  3. The repo has now been archived.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Matthew Deng <matt@anyscale.com>
@can-anyscale
Copy link
Collaborator

some doc tests are failing; otherwise ci change looks great, thanks for doing this matt

Signed-off-by: Matthew Deng <matt@anyscale.com>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a bit more of explanation for removing in the PR description (library is not maintained, 3.11 support, etc.)? Thanks!

Copy link
Member

@woshiyyya woshiyyya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any other searchers to deprecate?

@matthewdeng matthewdeng merged commit 396e0bf into ray-project:master Mar 14, 2024
9 checks passed
@angelinalg
Copy link
Contributor

Love the purging and maintenance! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants