Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Data] Move imports into TFPRedictor in batch inference example #44434

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

bveeramani
Copy link
Member

Why are these changes needed?

We're updating our CI to use Python 3.11. Accordingly, we're updating the TensorFlow version to 2.15. To avoid test failures from #44274, this PR moves the TensorFlow imports into the TFPredictor methods.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: Balaji Veeramani <balaji@anyscale.com>
@bveeramani
Copy link
Member Author

cc @can-anyscale

@can-anyscale
Copy link
Collaborator

beautiful, thank you

Copy link
Contributor

@c21 c21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!

@bveeramani bveeramani merged commit 787990e into ray-project:master Apr 3, 2024
5 checks passed
@bveeramani bveeramani deleted the fix-doc-test branch April 3, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants