Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] Cleanup all env-checking functionality from RLlib (except MultiAgentEnv). #44891

Merged
merged 7 commits into from
Apr 24, 2024

Conversation

sven1977
Copy link
Contributor

Cleanup all env-checking functionality from RLlib.

  • Except for checking MultiAgentEnv implementations by users (to be debated whether we need these checks or not).
  • We are moving toward new API stack: No BaseEnv, VectorEnv, RemoteEnv, etc.. Only pure gym.Envs -> RLlib should not be concerned with checking these as gym comes with its own pre-check functionalities.
  • We are leaving the MultiAgentEnv check in place and activate it inside MultiAgentEnvRunner for the time being. However, we will also simplify this API in the near future (e.g. get rid of action_space_sample, observation_space_sample, and other methods that seem superfluous or only there, b/c RLlib's old BaseEnv required these).

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might need in some cases the disable_env_checker in the env_config - also good for examples to show users how to do it (even though obvious for pros :)).

@@ -443,7 +443,7 @@ def do_test_nested_tuple(self, make_env):
config = (
PPOConfig()
.experimental(_disable_preprocessor_api=True)
.environment("nested2", disable_env_checking=True)
.environment("nested2")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder, if we need instead to pass in disable_env_checker to the env_config such that gym.make does not check (e.g. in MultiAGentEnv?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to have some of these in our examples. Still, we should probably step back and watch from the sidelines as this is a purely gymnasium issue. Similar to us also NOT checking, whether users write a functioning torch.nn.Module or configure their custom torch.optim.Adam correctly.

Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 merged commit 24539f8 into ray-project:master Apr 24, 2024
5 checks passed
@sven1977 sven1977 deleted the algorithm_config_cleanup branch April 24, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants