-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RLlib] Cleanup all env-checking functionality from RLlib (except MultiAgentEnv). #44891
[RLlib] Cleanup all env-checking functionality from RLlib (except MultiAgentEnv). #44891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Might need in some cases the disable_env_checker
in the env_config
- also good for examples to show users how to do it (even though obvious for pros :)).
@@ -443,7 +443,7 @@ def do_test_nested_tuple(self, make_env): | |||
config = ( | |||
PPOConfig() | |||
.experimental(_disable_preprocessor_api=True) | |||
.environment("nested2", disable_env_checking=True) | |||
.environment("nested2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder, if we need instead to pass in disable_env_checker
to the env_config
such that gym.make
does not check (e.g. in MultiAGentEnv
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed to have some of these in our examples. Still, we should probably step back and watch from the sidelines as this is a purely gymnasium issue. Similar to us also NOT checking, whether users write a functioning torch.nn.Module
or configure their custom torch.optim.Adam
correctly.
…rithm_config_cleanup
Cleanup all env-checking functionality from RLlib.
MultiAgentEnv
implementations by users (to be debated whether we need these checks or not).MultiAgentEnvRunner
for the time being. However, we will also simplify this API in the near future (e.g. get rid ofaction_space_sample
,observation_space_sample
, and other methods that seem superfluous or only there, b/c RLlib's old BaseEnv required these).Why are these changes needed?
Related issue number
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.