[serve] fix lightweight update max ongoing requests #45006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcin
changed the title
zcin
force-pushed
the
pr45006
branch
2 times, most recently
from
ca48357
to
fe48404
Compare
When a lightweight update occurs for a deployment and `max_ongoing_requests` is updated, two components need to be notified: 1. Deployment handles, to know not to send more requests to a replica when it's reached its maximum 2. Replicas, to know to reject requests when it's reached its maximum Right now we handle (1), but we don't handle (2), i.e. replicas aren't notified of the updated `max_ongoing_requests` for lightweight updates. The problem is that (1) is not strict enforcement of `max_ongoing_requests` since it relies on a cache that can be stale, so the current bug is that replicas aren't updated -> updated max is not fully enforced. This PR fixes that, and updates a test to fully test this behavior. Fixes ray-project#44975. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
shrekris-anyscale
approved these changes
Apr 29, 2024
| @@ -117,7 +117,7 @@ class DeploymentConfig(BaseModel): | |||
| ) | |||
| max_ongoing_requests: PositiveInt = Field( | |||
| default=DEFAULT_MAX_ONGOING_REQUESTS, | |||
| update_type=DeploymentOptionUpdateType.NeedsReconfigure, | |||
| update_type=DeploymentOptionUpdateType.NeedsActorReconfigure, | |||
There was a problem hiding this comment.
What is the behavior if the number of queued requests exceeds the new max? Does the replica simply drain the queue until it reaches the new max before accepting new requests?
harborn
pushed a commit
to harborn/ray
that referenced
this pull request
May 8, 2024
[serve] fix lightweight update max ongoing requests When a lightweight update occurs for a deployment and `max_ongoing_requests` is updated, two components need to be notified: 1. Deployment handles, to know not to send more requests to a replica when it's reached its maximum 2. Replicas, to know to reject requests when it's reached its maximum Right now we handle (1), but we don't handle (2), i.e. replicas aren't notified of the updated `max_ongoing_requests` for lightweight updates. The problem is that (1) is not strict enforcement of `max_ongoing_requests` since it relies on a cache that can be stale, so the current bug is that replicas aren't updated -> updated max is not fully enforced. This PR fixes that, and updates a test to fully test this behavior. Fixes ray-project#44975. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
ryanaoleary
pushed a commit
to ryanaoleary/ray
that referenced
this pull request
Jun 7, 2024
[serve] fix lightweight update max ongoing requests When a lightweight update occurs for a deployment and `max_ongoing_requests` is updated, two components need to be notified: 1. Deployment handles, to know not to send more requests to a replica when it's reached its maximum 2. Replicas, to know to reject requests when it's reached its maximum Right now we handle (1), but we don't handle (2), i.e. replicas aren't notified of the updated `max_ongoing_requests` for lightweight updates. The problem is that (1) is not strict enforcement of `max_ongoing_requests` since it relies on a cache that can be stale, so the current bug is that replicas aren't updated -> updated max is not fully enforced. This PR fixes that, and updates a test to fully test this behavior. Fixes ray-project#44975. Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[serve] fix lightweight update max ongoing requests
When a lightweight update occurs for a deployment and
max_ongoing_requestsis updated, two components need to be notified:Right now we handle (1), but we don't handle (2), i.e. replicas aren't notified of the updated
max_ongoing_requestsfor lightweight updates. The problem is that (1) is not strict enforcement ofmax_ongoing_requestssince it relies on a cache that can be stale, so the current bug is that replicas aren't updated -> updated max is not fully enforced.This PR fixes that, and updates a test to fully test this behavior.
Fixes #44975.
Signed-off-by: Cindy Zhang cindyzyx9@gmail.com