[tune] Fix PB2 scheduler error resulting from trying to sort by Trial
objects
#45161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Very minor change solving a bug for the PB2 scheduler in tune: The dataframe storing the Trials should have its first column being of string type (for instance, here); However, in one case, it is stored as a
Trial
type instead, leading to a comparison error when the dataframe is sorted (which e.g. happens by default in thegroupby
operations)Related issue number
Closes #37638.
(I believe this may also close #14187 although it's an older issue)
Checks
git commit -s
) in this PR.scripts/format.sh
to lint the changes in this PR.method in Tune, I've added it in
doc/source/tune/api/
under thecorresponding
.rst
file.