Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tune] Fix PB2 scheduler error resulting from trying to sort by Trial objects #45161

Merged
merged 1 commit into from
May 16, 2024

Conversation

ameroyer
Copy link
Contributor

@ameroyer ameroyer commented May 6, 2024

Why are these changes needed?

Very minor change solving a bug for the PB2 scheduler in tune: The dataframe storing the Trials should have its first column being of string type (for instance, here); However, in one case, it is stored as a Trial type instead, leading to a comparison error when the dataframe is sorted (which e.g. happens by default in the groupby operations)

Related issue number

Closes #37638.
(I believe this may also close #14187 although it's an older issue)

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • [] I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • [] Unit tests
    • [] Release tests
    • This PR is not tested :(

make sure Trial column entry is always saved as a string in the pandas dataframe

Signed-off-by: Amélie Royer <amelie.royer@ens-rennes.fr>
Copy link
Contributor

@justinvyu justinvyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix!

@justinvyu justinvyu changed the title PB2 Bug Fix [tune] Fix PB2 scheduler error resulting from trying to sort by Trial objects May 8, 2024
@justinvyu justinvyu merged commit ac2408c into ray-project:master May 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tune] Pandas sorting error inPB2 [tune] PB2 tries to compare trial and string
2 participants