Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data] add debugging info for SplitCoordinator #45226

Merged
merged 2 commits into from
May 9, 2024
Merged

[data] add debugging info for SplitCoordinator #45226

merged 2 commits into from
May 9, 2024

Conversation

raulchen
Copy link
Contributor

@raulchen raulchen commented May 9, 2024 •
edited
Loading

Why are these changes needed?

Add debugging info to debug #45225.
The bug is hard to reproduce manually. Add debugging info, so that when it happens, we have enough info to investigate the issue.

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@raulchen
[data] add debugging info for SplitCoordinator
ca65052 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen
fix
c9a44d0 
Signed-off-by: Hao Chen <chenh1024@gmail.com>
@raulchen raulchen merged commit adc18b8 into ray-project:master May 9, 2024
5 checks passed
@raulchen raulchen deleted the debug-streaming-split branch May 9, 2024 22:48
HenryZJY pushed a commit to HenryZJY/ray that referenced this pull request May 10, 2024
@raulchen @HenryZJY
[data] add debugging info for SplitCoordinator (ray-project#45226)
623dfd6 
Add debugging info to debug
ray-project#45225.
The bug is hard to reproduce manually. Add debugging info, so that when
it happens, we have enough info to investigate the issue.
---------

Signed-off-by: Hao Chen <chenh1024@gmail.com>
raulchen added a commit to raulchen/ray that referenced this pull request Aug 16, 2024
@raulchen
Revert "[data] add debugging info for SplitCoordinator (ray-project#4…
5dbb4c1 
…5226)"

This reverts commit adc18b8.

Signed-off-by: Hao Chen <chenh1024@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c21 c21 c21 approved these changes

@ericl ericl Awaiting requested review from ericl

@scv119 scv119 Awaiting requested review from scv119

@amogkam amogkam Awaiting requested review from amogkam

@scottjlee scottjlee Awaiting requested review from scottjlee scottjlee is a code owner

@bveeramani bveeramani Awaiting requested review from bveeramani bveeramani is a code owner

@stephanie-wang stephanie-wang Awaiting requested review from stephanie-wang stephanie-wang is a code owner

@omatthew98 omatthew98 Awaiting requested review from omatthew98 omatthew98 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raulchen @c21