Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Improve doc for --object-store-memory to describe how the default value is set #45301

Merged
merged 2 commits into from
May 29, 2024

Conversation

jjyao
Copy link
Collaborator

@jjyao jjyao commented May 13, 2024

Why are these changes needed?

Currently it's unclear how the default value is set

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

…ue is set

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Copy link
Contributor

@ruisearch42 ruisearch42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change, otherwise LGTM.

python/ray/_private/worker.py Outdated Show resolved Hide resolved
python/ray/scripts/scripts.py Outdated Show resolved Hide resolved
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
@jjyao jjyao enabled auto-merge (squash) May 29, 2024 18:43
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 29, 2024
@can-anyscale can-anyscale merged commit d76518f into ray-project:master May 29, 2024
6 of 8 checks passed
@jjyao jjyao deleted the jjyao/docf branch May 29, 2024 21:41
richardsliu pushed a commit to richardsliu/ray that referenced this pull request Jun 12, 2024
…ult value is set (ray-project#45301)

Currently it's unclear how the default value is set

Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
Signed-off-by: Richard Liu <ricliu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants