Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RLlib] Cleanup examples folder 11: Example for using fractional GPUs on the Learners. #45379

Merged
merged 19 commits into from
May 17, 2024
Merged

[RLlib] Cleanup examples folder 11: Example for using fractional GPUs on the Learners. #45379

merged 19 commits into from
May 17, 2024

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented May 16, 2024 •
edited
Loading

Cleanup examples folder 11: Add example on how to use fractional GPUs on the Learners.

  • Add tests to CI for running: 4 (trials) x 0.2 (GPUs) load on a single GPU machine AND 4 (trials) x 0.5 GPUs on a multi-GPU machine.

Why are these changes needed?

Related issue number

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977
wip
cb937c6 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
c931bed 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
02d3d04 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
3ada50a 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into algo…
bccdde6 
…rithm_config_dissolve_resources_method
@sven1977
wip
496c5ee 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into clea…
edd0a91 
…nup_examples_folder_11_fractional_gpus
@sven1977
Merge branch 'algorithm_config_dissolve_resources_method' into cleanu…
4cdebb3 
…p_examples_folder_11_fractional_gpus
@sven1977
wip
68aa7ba 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
wip
794b960 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'algorithm_config_dissolve_resources_method' into cleanu…
3a6d05e 
…p_examples_folder_11_fractional_gpus

# Conflicts:
#	rllib/utils/test_utils.py
@sven1977
wip
03be7f5 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 requested a review from a team as a code owner May 16, 2024 04:59
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into clea…
d72d1ed 
…nup_examples_folder_11_fractional_gpus

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	doc/source/rllib/rllib-learner.rst
#	rllib/algorithms/algorithm_config.py
#	rllib/utils/test_utils.py
@sven1977
fix
38079b8 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into clea…
4c5ac20 
…nup_examples_folder_11_fractional_gpus

Signed-off-by: sven1977 <svenmika1977@gmail.com>

# Conflicts:
#	rllib/utils/test_utils.py
@sven1977
fix
fadc100 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
simonsays1980
simonsays1980 approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@simonsays1980 simonsays1980 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Specifically the change in the test utils will clear some ambiguities.

rllib/utils/test_utils.py
@@ -1358,6 +1359,11 @@ def run_rllib_example_script_experiment(
tune_callbacks: A list of Tune callbacks to configure with the tune.Tuner.
In case `args.wandb_key` is provided, will append a WandB logger to this
list.
keep_config: Set this to True, if you don't want this utility to change the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Very nice. Had a couple of cases where my config was changed unintendedly by the function and it was ambiguous what happened.

@sven1977
Merge branch 'master' of https://github.com/ray-project/ray into clea…
ec10c87 
…nup_examples_folder_11_fractional_gpus
@sven1977
fix
71a849f 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977
fix
0ff34a7 
Signed-off-by: sven1977 <svenmika1977@gmail.com>
@sven1977 sven1977 enabled auto-merge (squash) May 17, 2024 11:21
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label May 17, 2024
@sven1977 sven1977 merged commit 86ae5e8 into ray-project:master May 17, 2024
8 checks passed
@sven1977 sven1977 deleted the cleanup_examples_folder_11_fractional_gpus branch May 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonsays1980 simonsays1980 simonsays1980 approved these changes

@avnishn avnishn Awaiting requested review from avnishn

@ArturNiederfahrenhorst ArturNiederfahrenhorst Awaiting requested review from ArturNiederfahrenhorst

@maxpumperla maxpumperla Awaiting requested review from maxpumperla

@kouroshHakha kouroshHakha Awaiting requested review from kouroshHakha

Assignees

@simonsays1980 simonsays1980

Labels
go add ONLY when ready to merge, run all tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sven1977 @simonsays1980