Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc][api] remove deprecated api #45841

Closed
wants to merge 1 commit into from
Closed

[doc][api] remove deprecated api #45841

wants to merge 1 commit into from

Conversation

can-anyscale
Copy link
Collaborator

@can-anyscale can-anyscale commented Jun 10, 2024

Remove set_progress_bar (https://github.com/ray-project/ray/blob/master/python/ray/data/_internal/progress_bar.py#L24) from doc since it is a deprecated API (#43575). It is also an internal function.

Test:

  • CI

Signed-off-by: can <can@anyscale.com>
@bveeramani
Copy link
Member

Just summarizing what we discussed offline -- this API is currently "soft deprecated," meaning it's labeled as Deprecated and raises a warning. Before we remove this from the code, let's "hard deprecate" it (make it raise an error rather than a warning).

@can-anyscale
Copy link
Collaborator Author

@angelinalg sorry i'm still confused about when we will remove the @deprecated api in the doc; there are hundreds of @deprecated api in our code, so if we go with @deprecated api also need to be in the doc that will be a lot of additions

@bveeramani
Copy link
Member

bveeramani commented Jun 10, 2024

For Data, there are 9 deprecated APIs. We can remove 5 of them. 3 of them we plan to never remove and keep deprecated for backwards-compatibility reasons. The remaining API is set_progress_bars, which should be hard deprecated.

Looks like most of the deprecated API in the rest of the codebase are in RLlib. I'm not sure what deprecation policy RLlib adheres to.

@bveeramani
Copy link
Member

Here's a PR to remove all of the eligible deprecated Data APIs: #45850

@can-anyscale
Copy link
Collaborator Author

thanks @bveeramani, noted, let's close this and i'll follow up with another PR so we can specify a concrete date under the @Deprecation annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants