[serve] configure logging for build app task #46347
Conversation
zcin
force-pushed
the
pr46347
branch
3 times, most recently
from
2f561cc
to
f6c89eb
Compare
| Returns: | ||
| Deploy arguments: a list of deployment arguments if application | ||
| was built successfully, otherwise None. | ||
| Error message: a string if an error was raised, otherwise None. | ||
| """ | ||
| configure_component_logger( | ||
| component_name=f"build_{name}_task", |
There was a problem hiding this comment.
My only concern is this component name. Currently in Serve we have controller, proxy, and replica. Can definitely add a new type for this, but given this is free formed, it might be hard for users to find them on the platform. Also, depending on whether we want to show these by default, we might want to follow up with a product change to add a new component name filter in the log viewer UI.
There was a problem hiding this comment.
synced offline, setting component name to "controller" and setting component id to build_default_pid. Since the component name is used for filtering logs, creating a new component name for the build task is confusing and hard to find. It makes the most sense to group it under controller logs.
There was a problem hiding this comment.
sounds like the right approach to me too. we can always iterate
zcin
force-pushed
the
pr46347
branch
2 times, most recently
from
1c3f6a9
to
c09bd44
Compare
Configure logging for the `build_serve_application` task. Although it is a short-lived task, it is part of every application deployment process, and this can improve observability for the deployment process.
Added some light logging to the task as well.
Example:
```
INFO 2024-07-01 16:54:13,660 build_default_task 15893 application_state.py:1047 - Importing application 'default'.
WARNING 2024-07-01 16:54:13,660 build_default_task 15893 api.py:432 - The default value for `max_ongoing_requests` has changed from 100 to 5 in Ray 2.32.0.
ERROR 2024-07-01 16:54:13,661 build_default_task 15893 application_state.py:1077 - Exception importing application 'default'.
Traceback (most recent call last):
File "/Users/cindyz/ray/python/ray/serve/_private/application_state.py", line 1049, in build_serve_application
app = call_app_builder_with_args_if_necessary(import_attr(import_path), args)
File "/Users/cindyz/ray/python/ray/_private/utils.py", line 1194, in import_attr
return getattr(module, attr_name)
AttributeError: module 'hello' has no attribute 'haa'
```
Signed-off-by: Cindy Zhang <cindyzyx9@gmail.com>
|
@edoakes tests are passing, is this ready to merge? |
[serve] configure logging for build app task
Configure logging for the
build_serve_applicationtask. Although it is a short-lived task, it is part of every application deployment process, and this can improve observability for the deployment process.Added some light logging to the task as well.
Example:
Signed-off-by: Cindy Zhang cindyzyx9@gmail.com