Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Train] Replace lambda default arguments #46576

Conversation

peytondmurray
Copy link
Contributor

Why are these changes needed?

This PR fixes instances where lambda functions are used as default arguments. Since default arguments are evaluated at function definition time, mutable objects can have unintuitive behavior; additionally, they prevent our documentation from rendering correctly. This PR is part of #45129, but has been split up to minimize codeowner impact.

Related issue number

Partially addresses #45129.

Checks

  • I've signed off every commit(by using the -s flag, i.e., git commit -s) in this PR.
  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
    • I've added any new APIs to the API Reference. For example, if I added a
      method in Tune, I've added it in doc/source/tune/api/ under the
      corresponding .rst file.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

Signed-off-by: pdmurray <peynmurray@gmail.com>
@peytondmurray peytondmurray added docs An issue or change related to documentation train Ray Train Related Issue labels Jul 11, 2024
@matthewdeng matthewdeng enabled auto-merge (squash) July 15, 2024 20:24
@github-actions github-actions bot added the go add ONLY when ready to merge, run all tests label Jul 15, 2024
@matthewdeng matthewdeng merged commit aeb92f2 into ray-project:master Jul 15, 2024
6 checks passed
@peytondmurray peytondmurray deleted the 45129-fix-train-bad-type-annotation branch July 16, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs An issue or change related to documentation go add ONLY when ready to merge, run all tests train Ray Train Related Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants