-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit number of parallel GHA runs, print env info in tests #52
Conversation
Well, it seems it doesn't solve the problem. Consider this a draft PR, I'll look into how to fix this later |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting- great catch!
Though it still looks like 2 of the jobs are failing. |
Yes :-( Maybe we can move this to buildkite? |
Ah sorry, I missed your comment about it not solving the problem. Do you think that it has to do with using the ray cluster fixture with unittest.testCase? Perhaps we should try switching back to pytest for test_colocation. |
I don't think this is related to that, the tests were flaky before that change. I mean, we can try, I'll create a revert PR just in case |
Doesn't seem to be possible from within GitHub. I might try it manually tomorrow |
@krfricke should we merge this? |
Yeah let's do it, though it doesn't solve the problem completely. But it is a good start in any case. Thanks for reminding me! |
Unfortunately GHA runs are sometimes aborted due to memory limits. Reducing the number of concurrent trials increases our test time to 2x, but at least these errors stop coming up.