-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat add recap view for pomodoro extention #11944
Conversation
feat: add detail page to display the count of timer cycles
Thank you for your contribution! 🎉 🔔 @KELiON @pernielsentikaer @brodelp @susonthapa @mikikiv @MartinGonzalez @Nathanjms you might want to have a look. |
Thanks for the typo ! @pernielsentikaer |
function countTotalFocusTime(intervals: Interval[]) { | ||
let total = 0; | ||
for (const interval of intervals) { | ||
for (const part of interval.parts) { | ||
if (part.endAt) { | ||
total += interval.length; | ||
} | ||
} | ||
} | ||
return total; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be filtered to only count interval.type === "focus"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you help here @cchalop1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes you are right. I'm going to fix it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ok for you @mikikiv ?
Just waiting for @KELiON do check it now 🙂 |
I haven't tested it well yet, but we can maybe optimize
|
Yes I agree with you, it is clearer if we put everything in the calculatesStats function. I push for change |
I hope I didn't break something since I didn't have any data to test with 🙂 Is this ready for another review? |
I have tested with my local data and i work well. Yep it is ready ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi 👋
Looks good to me, approved 🔥
Published to the Raycast Store: |
🎉 🎉 🎉 Such a great contribution deserves a reward, but unfortunately we couldn't find your Raycast account based on your GitHub username (@cchalop1). |
Description
I have had a recap page for pomodoro extention.
The goal is to have a page for resume all the data from the your previous pomodoro cycle.
I have had 3 informations:
I thinks we can add more informations in futures but we can make a other PR for that.
fix #11054
Screencast
Checklist
npm run build
and tested this distribution build in Raycastassets
folder are used by the extension itselfREADME
are placed outside of themetadata
folder