Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add syntax-fm extension #12021

Merged
merged 3 commits into from
May 2, 2024
Merged

Add syntax-fm extension #12021

merged 3 commits into from
May 2, 2024

Conversation

msmps
Copy link
Contributor

@msmps msmps commented Apr 26, 2024

Description

The aim of this extension is to have one of my favourite podcasts syntax.fm at your fingertips! ✨

It currently supports searching for episodes, opening directly on the syntax.fm website, opening on YouTube (if a video is present) and finally opening in the Apple Music application.

I plan on iterating on this, adding background checks to check for new episodes, and adding support to open directly in Spotify, but first I need to open an issue or contribute back to syntax to include the Spotify information for each track.

I think my only outstanding question is how to best cache the data from the useFetch hook and/or if we should consider pagination at this stage. The endpoint I'm using doesn't currently support pagination.

Screencast

Screen.Recording.2024-04-26.at.14.45.15.mp4

Checklist

@raycastbot raycastbot added the new extension Label for PRs with new extensions label Apr 26, 2024
@raycastbot
Copy link
Collaborator

Congratulations on your new Raycast extension! 🚀

We will aim to make the initial review within five working days. Once the PR is approved and merged, the extension will be available on our Store.

@msmps
Copy link
Contributor Author

msmps commented Apr 26, 2024

Hey @wesbos @stolinski 👋 I read through the Syntax Terms of Service, and nothing stood out to me. I just want to make sure you're both happy with this and the consumption of the content.json endpoint.

@stolinski
Copy link

Sick! Thank you @msmps

Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Thanks for your contribution 💪

I have now tested your extension, and I have some feedback ready for you:

The data is already cached when you're using useFetch from @raycast/utils, it will show the cached data while getting fresh data from the endpoint so it should be fine 🙂

I'm looking forward to testing this extension again 🔥

Request a new review when you are ready. Feel free to contact me here or at Slack if you have any questions.

extensions/syntax-fm/src/search.tsx Show resolved Hide resolved
extensions/syntax-fm/package.json Show resolved Hide resolved
@pernielsentikaer pernielsentikaer self-assigned this May 2, 2024
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi 👋

Looks good to me, approved 🔥

@raycastbot raycastbot merged commit 581caca into raycast:main May 2, 2024
2 checks passed
Copy link
Contributor

github-actions bot commented May 2, 2024

Published to the Raycast Store:
https://raycast.com/msmps/syntax-fm

@raycastbot
Copy link
Collaborator

🎉 🎉 🎉

We've rewarded your Raycast account with some credits. You will soon be able to exchange them for some swag.

@wesbos
Copy link
Contributor

wesbos commented May 2, 2024

DAMN this is SO cool! Thanks a ton for doing this.

We have a new logo, I'm gonna PR it right now

@pernielsentikaer
Copy link
Collaborator

do-it-gif

@wesbos
Copy link
Contributor

wesbos commented May 2, 2024

cloning the repo. Give me 3 days

@msmps
Copy link
Contributor Author

msmps commented May 2, 2024

DAMN this is SO cool! Thanks a ton for doing this.

We have a new logo, I'm gonna PR it right now

@wesbos Awesome, thanks! You're very welcome. I just wanted to contribute something back to the podcast. 🚀

@msmps msmps deleted the ext/syntax-fm branch May 2, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new extension Label for PRs with new extensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants