Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transmission extension #148

Merged
merged 20 commits into from
Oct 26, 2021
Merged

transmission extension #148

merged 20 commits into from
Oct 26, 2021

Conversation

FezVrasta
Copy link
Contributor

@FezVrasta FezVrasta commented Oct 20, 2021 •
edited
Loading

Description

The goal is to create an extension to view, control, and add torrents using the transmission-daemon as server.

Todo:

  • Add start/stop actions for specific torrent
  • Add way to add new torrent from magnet (and if possible .torrent file?)
  • Add configuration page
  • Show per-torrent down/up speed
  • Show suitable icon for each state
  • add sorting preferences
  • Remove torrent
  • Quick paths list to quickly choose a destination when a torrent is added
  • Start/Stop all torrents
  • Show total down/up speed
  • Fuzzy search

Future ideas:

  • Torrent details page
  • Move torrent to different destination
  • Open file in finder
  • Multiple servers support

Not implementable because of missing API:

Type of change

  • New extension

Screencast

CleanShot.2021-10-23.at.17.42.04.mp4

Checklist

@PitNikola PitNikola added the new extension Label for PRs with new extensions label Oct 20, 2021
@FezVrasta FezVrasta marked this pull request as ready for review October 21, 2021 12:31
@dev99problems dev99problems mentioned this pull request Oct 22, 2021
Merged
@PitNikola PitNikola self-requested a review October 22, 2021 19:54
@PitNikola PitNikola self-assigned this Oct 22, 2021
@PitNikola PitNikola removed their request for review October 25, 2021 12:51
pernielsentikaer
pernielsentikaer requested changes Oct 25, 2021
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FezVrasta 👋

What an awesome extension, looking forward to following it all the way from here 💯

Besides the suggestions below you could maybe look into a bit better handling if the "connection refused" - if you need examples I can provide some more details.

08W3eb3dTMHvGb1w

Request a new review or catch me here at the slack channel if you want to discuss anything 😄

extensions/transmission/package.json Outdated Show resolved Hide resolved
extensions/transmission/package.json Outdated Show resolved Hide resolved
extensions/transmission/package.json Outdated Show resolved Hide resolved
FezVrasta and others added 2 commits October 25, 2021 16:38
@FezVrasta
Update extensions/transmission/package.json
bec0fab 
Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
@FezVrasta
Update extensions/transmission/package.json
e8e7e80 
Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
@FezVrasta
Copy link
Contributor Author

Besides the suggestions below you could maybe look into a bit better handling if the "connection refused" - if you need examples I can provide some more details.

I see what's going on, I did handle that but some recent changes broken that logic, I'll fix that, thanks.

@FezVrasta
Copy link
Contributor Author

Feedback should be addressed

pernielsentikaer
pernielsentikaer approved these changes Oct 26, 2021
View reviewed changes
Copy link
Collaborator

@pernielsentikaer pernielsentikaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FezVrasta 👋

Awesome work with this extension, I reviewed the last part, and for me, it's looking very good.

We're about to ship it 🚢

@mattisssa mattisssa merged commit 34b8b27 into raycast:main Oct 26, 2021
@FezVrasta FezVrasta deleted the transmission branch October 26, 2021 11:56
FezVrasta pushed a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
@PitNikola @FezVrasta
GitBook: [raycast#148] Add link to store guidelines
c6f73a9
FezVrasta added a commit to FezVrasta/extensions that referenced this pull request Nov 24, 2021
@FezVrasta
transmission extension (raycast#148)
fd2022d 
* transmission extension

* fix filename

* feat: add start/stop actions

* added icons, prefs page, sorting

* feat: display up/down speed for each torrent

* add new torrents and icon

* fix progress icon

* stop loading if no torrents are available

* fix extension path and “done” status icon

* add quick paths option

* improve add torrent page

* improve list padding

* start/stop all torrents

* add readme

* add total up/down stats

* implement fuzzy search

* fix file name

* Update extensions/transmission/package.json

Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>

* Update extensions/transmission/package.json

Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>

* address feedback

Co-authored-by: Per Nielsen Tikær <pnt@klean.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattisssa mattisssa mattisssa approved these changes

@pernielsentikaer pernielsentikaer pernielsentikaer approved these changes

Assignees

@pernielsentikaer pernielsentikaer

Labels
new extension Label for PRs with new extensions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FezVrasta @mattisssa @pernielsentikaer @PitNikola