Provides compatibility with zend-mvc v2.7.0 #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This package seems abandoned. Because I need this to be fixed, I've forked the branch and added it to packagist. Pull requests are very much welcome. https://github.com/netiul/DOMPDFModule |
|
Hi @Netiul and @marciodojr, This project did go through a period where it was not actively maintained. However, I am able to contribute/maintain this project once again. I will be looking for individuals soon who are motivated and have a stake in the success of DOMPDFModule. |
|
@marciodojr I ported your changes over since this PR is outdated with master. See https://github.com/raykolbe/DOMPDFModule/pull/60/files#diff-c1c8ed7a4ddcb50eea2143d9f3f5bc02R37 These changes are now in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@raykolbe
Since version 2.7.0 of zend-mvc component, the ViewManager no longer has the methods
getResolver()andgetRenderer(). TheViewResolverandViewRenderernow must be instanciated by factories.Without these changes the DOMPDFModule will not work anymore with zend-mvc >= 2.7.0.