Feature/add authentication to check images on registries #42

dbalucas · 2023-08-16T07:37:30Z

During the first test we have faced issues with docker registries where you have to provide authentication for.

Therefore different features were added:

feature to authenticate against docker hub because it behaves special
a logic for most know registries like github.io, quay.io, ...
special handling for registries which require authentication, but credentials aren't available (usage of a default/general access-token)

This PR should add this logics and as well include test cases therefore.

raynigon

Please split the encoding into a seperate PR and request review again

.github/scripts/increment_version.py

setup.py

src/lennybot/__init__.py

src/lennybot/actions/download_resources.py

src/lennybot/actions/update_dockerfile.py

src/lennybot/actions/update_image_tag.py

src/lennybot/actions/update_yaml.py

src/lennybot/config/config.py

src/lennybot/model/state.py

version.txt

raynigon

Please add test case and correct the logic for registries without credentials

src/lennybot/check/docker_image_available.py

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

remove blocked registry improves the handling of urls and parsing

increase readability res -> response

test/config/test_config.py

version.txt

versions.state.yaml

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

remove blocked registry improves the handling of urls and parsing

increase readability res -> response

…s' of https://github.com/raynigon/lennybot into feature/add-authentication-to-check-images-on-registries

…n-registries

dbalucas

test works fine.
logic is setup.
pyright was introduced.
pylint is 10.0.
black and isort done.

raynigon

LGTM

src/lennybot/check/docker_image_available.py

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

dbalucas requested a review from raynigon August 16, 2023 07:37

dbalucas marked this pull request as draft August 16, 2023 07:37

dbalucas changed the title ~~WIP: Feature/add authentication to check images on registries~~ Feature/add authentication to check images on registries Aug 16, 2023

dbalucas marked this pull request as ready for review August 16, 2023 07:46

raynigon requested changes Aug 16, 2023

View reviewed changes

dbalucas added 6 commits August 16, 2023 11:02

implement auth for registry

39dc00d

implement auth for registry

da77f92

implement auth for registry

459ba0a

set USERNAME as sticky for ghcr

7480518

black and isort

d7a1173

implement auth for docker.elastic registry

534ac72

raynigon force-pushed the feature/add-authentication-to-check-images-on-registries branch from 0e91b13 to 534ac72 Compare August 16, 2023 09:02

Update version.txt

de512a5

raynigon requested changes Aug 16, 2023

View reviewed changes

raynigon reviewed Aug 16, 2023

View reviewed changes

src/lennybot/check/docker_image_available.py Outdated Show resolved Hide resolved

raynigon reviewed Aug 16, 2023

View reviewed changes

src/lennybot/check/docker_image_available.py Outdated Show resolved Hide resolved

raynigon reviewed Aug 16, 2023

View reviewed changes

src/lennybot/check/docker_image_available.py Outdated Show resolved Hide resolved

dbalucas and others added 5 commits August 16, 2023 11:14

use url_encode_params instead of string

41a4c18

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

manifacture

78d7729

remove blocked registry improves the handling of urls and parsing

manifacture WwwAuthentication as a class

8380775

increase readability res -> response

manifacture WwwAuthentication as a class

62116ab

increase readability res -> response

fix bug due to typo

5673359

This comment was marked as outdated.

Sign in to view

dbalucas and others added 2 commits August 17, 2023 16:36

Update test/lennybot.yaml

09c12b1

fix pytest and add some comments

d3cef9e

raynigon reviewed Aug 18, 2023

View reviewed changes

test/config/test_config.py Outdated Show resolved Hide resolved

raynigon reviewed Aug 18, 2023

View reviewed changes

version.txt Outdated Show resolved Hide resolved

raynigon reviewed Aug 18, 2023

View reviewed changes

versions.state.yaml Outdated Show resolved Hide resolved

dbalucas added 2 commits August 18, 2023 09:18

Delete version.txt

b7c35e4

Delete versions.state.yaml

0b0de58

dbalucas and others added 14 commits August 21, 2023 11:51

set USERNAME as sticky for ghcr

fb60e25

black and isort

1f0f4f4

implement auth for docker.elastic registry

c8f57ab

Update version.txt

977e86c

use url_encode_params instead of string

c85269c

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

manifacture

7e44312

remove blocked registry improves the handling of urls and parsing

manifacture WwwAuthentication as a class

00ba7b1

increase readability res -> response

manifacture WwwAuthentication as a class

dfc91e9

increase readability res -> response

fix bug due to typo

4338101

Update test/lennybot.yaml

b398290

fix pytest and add some comments

726c986

Delete version.txt

fab4e4f

Delete versions.state.yaml

38af5bc

fix pytest and add some comments

a88efbe

raynigon force-pushed the feature/add-authentication-to-check-images-on-registries branch from bf3bc5a to a88efbe Compare August 21, 2023 09:51

Merge branch 'feature/add-authentication-to-check-images-on-registrie…

08f1d49

…s' of https://github.com/raynigon/lennybot into feature/add-authentication-to-check-images-on-registries

dbalucas self-assigned this Aug 21, 2023

dbalucas and others added 6 commits August 23, 2023 11:57

Merge branch 'main' into feature/add-authentication-to-check-images-o…

427d966

…n-registries

add test to check authetication routines

2d1fb34

add test to check authetication routines

fc80b16

fix pyright of tests and fix test itself

7cb2d5d

fix linter issue

a27658d

fix pytest pipeline

7aebf42

dbalucas marked this pull request as ready for review August 23, 2023 12:50

dbalucas commented Aug 23, 2023

View reviewed changes

dbalucas requested a review from raynigon August 23, 2023 12:52

raynigon approved these changes Aug 23, 2023

View reviewed changes

src/lennybot/check/docker_image_available.py Outdated Show resolved Hide resolved

Update src/lennybot/check/docker_image_available.py

9fbe2ab

Co-authored-by: Simon Schneider <10846939+raynigon@users.noreply.github.com>

dbalucas merged commit 064ba6e into main Aug 23, 2023
7 checks passed

dbalucas deleted the feature/add-authentication-to-check-images-on-registries branch August 23, 2023 13:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/add authentication to check images on registries #42

Feature/add authentication to check images on registries #42

dbalucas commented Aug 16, 2023 •

edited

Loading

raynigon left a comment

raynigon left a comment

This comment was marked as outdated.

dbalucas left a comment

raynigon left a comment

Feature/add authentication to check images on registries #42

Feature/add authentication to check images on registries #42

Conversation

dbalucas commented Aug 16, 2023 • edited Loading

raynigon left a comment

Choose a reason for hiding this comment

raynigon left a comment

Choose a reason for hiding this comment

This comment was marked as outdated.

dbalucas left a comment

Choose a reason for hiding this comment

raynigon left a comment

Choose a reason for hiding this comment

dbalucas commented Aug 16, 2023 •

edited

Loading