core: Introduce ThreadPoolBuilder::use_current_thread. #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @cuviper |
emilio
force-pushed
the
use-current-thread
branch
from
b9836fa
to
cd65b76
Compare
|
Fixed the formatting of the tests, whoops. |
|
@cuviper review ping? Modulo the naming issue discussed above (happy to tweak as needed) I think this should be in decent shape? |
|
Also ideas to be able to test the error (deadlocking) case of calling |
|
Hi, sorry -- I'm going to be unavailable the rest of this week, but I'll try to get to this early next week. |
|
No worries, I was just making sure this didn't fall through the cracks, thanks! (And enjoy your time off if that's the reason for your availability :)). |
|
Gentle ping? |
cuviper
reviewed
Aug 11, 2023
cuviper
reviewed
Aug 11, 2023
emilio
force-pushed
the
use-current-thread
branch
from
cd65b76
to
b95fe39
Compare
emilio
force-pushed
the
use-current-thread
branch
7 times, most recently
from
327626a
to
38c411b
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Aug 29, 2023
…r=smaug,jnicol,supply-chain-reviewers This applies rayon-rs/rayon#1063 to our rayon-core. I'm hopeful it can be merged upstream soon, but meanwhile this seems worth having on its ow. Differential Revision: https://phabricator.services.mozilla.com/D186722
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Aug 29, 2023
…r=smaug,jnicol,supply-chain-reviewers This applies rayon-rs/rayon#1063 to our rayon-core. I'm hopeful it can be merged upstream soon, but meanwhile this seems worth having on its ow. Differential Revision: https://phabricator.services.mozilla.com/D186722
cuviper
reviewed
Sep 1, 2023
emilio
force-pushed
the
use-current-thread
branch
from
38c411b
to
8c840bd
Compare
cuviper
reviewed
Sep 2, 2023
emilio
force-pushed
the
use-current-thread
branch
2 times, most recently
from
d343448
to
10f1ee6
Compare
emilio
added a commit
to emilio/rayon
that referenced
this pull request
Sep 4, 2023
…oop. This was originally done for rayon-rs#1063, in order to reuse this to allow cleaning up the TLS data allocated by use_current_thread. We ended up not using that, but this refactoring seems useful on its own.
|
The |
cuviper
reviewed
Sep 19, 2023
See discussion in rayon-rs#1052. Closes rayon-rs#1052.
…thread. As per suggestion in rayon-rs#1052.
…e_current_thread.
…thread. Ideas for testing the "call cleanup function from a job" case would be great.
emilio
force-pushed
the
use-current-thread
branch
from
10f1ee6
to
40b59c0
Compare
|
OK, I think we're good to go -- thanks for your persistence! :) bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page.
|
cuviper
pushed a commit
to emilio/rayon
that referenced
this pull request
Sep 20, 2023
…oop. This was originally done for rayon-rs#1063, in order to reuse this to allow cleaning up the TLS data allocated by use_current_thread. We ended up not using that, but this refactoring seems useful on its own.
emilio
added a commit
to emilio/rayon
that referenced
this pull request
Sep 20, 2023
…oop. This was originally done for rayon-rs#1063, in order to reuse this to allow cleaning up the TLS data allocated by use_current_thread. We ended up not using that, but this refactoring seems useful on its own.
Thank you! |
bors bot
added a commit
that referenced
this pull request
Sep 20, 2023
1087: core: registry: Factor out "wait till out of work" part of the main loop. r=cuviper a=emilio This was originally done for #1063, in order to reuse this to allow cleaning up the TLS data allocated by use_current_thread. We ended up not using that, but this refactoring seems useful on its own, perhaps. Co-authored-by: Emilio Cobos Álvarez <emilio@crisal.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This generalizes the approach used by targets that don't support threading like
wasm, allowing the builder thread to be part of a new thread-pool.
This PR:
Feedback welcome.
clean_up_use_current_threadis not a great name, but Ithink it's descriptive, and maybe good enough given it's a rather niche API for
non-global pools?