Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't fail for missing configuration file #213

Merged
merged 1 commit into from
Feb 16, 2023
Merged

Conversation

kushsharma
Copy link
Member

Shield already supports taking configs from env but the cli fails if it didn't find a config file locally. It should either add validation to check if configs are present or continue the execution.

Shield already supports taking configs from env but the
cli fails if it didn't find a config file locally. It should
either add validation to check if configs are present or
continue the execution

Signed-off-by: Kush Sharma <thekushsharma@gmail.com>
@kushsharma kushsharma added the bug Something isn't working label Feb 16, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4195074144

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 50.851%

Totals Coverage Status
Change from base Build 4050928003: 0.0%
Covered Lines: 4333
Relevant Lines: 8521

💛 - Coveralls

@ravisuhag ravisuhag merged commit ebce42b into main Feb 16, 2023
@ravisuhag ravisuhag deleted the env-config branch February 16, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants