Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deploy grpc stream should be concurrent safe #86

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

kushsharma
Copy link
Member

No description provided.

@kushsharma kushsharma added the bug Something isn't working label Sep 23, 2021
@kushsharma kushsharma self-assigned this Sep 23, 2021
@coveralls
Copy link

coveralls commented Sep 23, 2021

Pull Request Test Coverage Report for Build 1268852086

  • 36 of 51 (70.59%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 69.992%

Changes Missing Coverage Covered Lines Changed/Added Lines %
job/dependency_resolver.go 3 5 60.0%
run/service.go 16 18 88.89%
api/handler/v1/runtime.go 3 14 21.43%
Totals Coverage Status
Change from base Build 1265910684: -0.1%
Covered Lines: 4427
Relevant Lines: 6325

💛 - Coveralls

@kushsharma kushsharma force-pushed the grpc-stream-err branch 12 times, most recently from ac88d48 to fa64ad7 Compare September 27, 2021 09:03
- if the client context is cancelled, cancel everything server side as well

Signed-off-by: Kush <thekushsharma@gmail.com>
@kushsharma kushsharma merged commit f853468 into main Sep 27, 2021
@kushsharma kushsharma deleted the grpc-stream-err branch September 27, 2021 09:41
@ravisuhag ravisuhag mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants