Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: optimise list jobs operation for airflow #95

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

kushsharma
Copy link
Member

  • only list jobs for airflow that belong to that namespace
  • turn off failing replay test temporarily

- only list jobs for airflow that belong to that namespace
- turn off failing replay test temporarily

Signed-off-by: Kush <thekushsharma@gmail.com>
@kushsharma kushsharma added the refactor Internal code improvement label Oct 5, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1306708979

  • 18 of 20 (90.0%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.09%) to 70.025%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ext/scheduler/airflow2/airflow.go 12 14 85.71%
Files with Coverage Reduction New Missed Lines %
job/replay_manager.go 7 80.95%
Totals Coverage Status
Change from base Build 1302624085: -0.09%
Covered Lines: 4476
Relevant Lines: 6392

💛 - Coveralls

@kushsharma kushsharma merged commit 089e4a6 into main Oct 5, 2021
@kushsharma kushsharma deleted the optimise-airflow-job-list branch October 5, 2021 06:56
@ravisuhag ravisuhag mentioned this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Internal code improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants