Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: receiver pkg structure #93

Merged
merged 8 commits into from
Apr 4, 2022
Merged

refactor: receiver pkg structure #93

merged 8 commits into from
Apr 4, 2022

Conversation

rahmatrhd
Copy link
Member

@rahmatrhd rahmatrhd commented Mar 29, 2022 •
edited
Loading

Dependency:

Changes:

  • change repository to accept and return domain.Receiver instead of model.Receiver
  • change repository and service methods to pass param by reference and remove returned struct
  • move http and slack service to plugins/receivers/
  • merge pkg/slacknotifier into slack receiver plugin

@rahmatrhd rahmatrhd marked this pull request as ready for review March 30, 2022 04:36
@whoAbhishekSah whoAbhishekSah changed the title refactor(receiver): receiver structure refactor refactor: receiver structure refactor Apr 4, 2022
@whoAbhishekSah whoAbhishekSah changed the title refactor: receiver structure refactor refactor: receiver pkg structure refactor Apr 4, 2022
@whoAbhishekSah whoAbhishekSah changed the title refactor: receiver pkg structure refactor refactor: receiver pkg structure Apr 4, 2022
@whoAbhishekSah whoAbhishekSah merged commit f2abf6b into main Apr 4, 2022
@whoAbhishekSah whoAbhishekSah deleted the refactor/receiver branch April 4, 2022 10:07
@whoAbhishekSah whoAbhishekSah mentioned this pull request May 11, 2022
Closed
ravisuhag pushed a commit that referenced this pull request Aug 21, 2022
@rahmatrhd
refactor: receiver pkg structure (#93)
a7e55b3 
* refactor(receiver): repository to receive and return domain

* refactor(receiver): pass receiver by reference and remove receiver from returned value

* refactor(receiver): move http and slack receiver service into plugins/receivers

* refactor(receiver): merge slacknotifier into slack service

* test(receiver): fix tests after refactor

* chore(receiver): remove unused struct declaration

* chore(receiver): update proto to remove validation in send slack notification api

* refactor(receiver): merge slack client into slack service
ravisuhag pushed a commit that referenced this pull request Aug 21, 2022
@rahmatrhd
refactor: receiver pkg structure (#93)
0a5a473 
* refactor(receiver): repository to receive and return domain

* refactor(receiver): pass receiver by reference and remove receiver from returned value

* refactor(receiver): move http and slack receiver service into plugins/receivers

* refactor(receiver): merge slacknotifier into slack service

* test(receiver): fix tests after refactor

* chore(receiver): remove unused struct declaration

* chore(receiver): update proto to remove validation in send slack notification api

* refactor(receiver): merge slack client into slack service
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whoAbhishekSah whoAbhishekSah whoAbhishekSah approved these changes

@pyadav pyadav Awaiting requested review from pyadav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rahmatrhd @whoAbhishekSah