refactor(rule): rule pkg structure #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s param as reference
rahmatrhd
force-pushed
the
refactor/rules
branch
from
2890709
to
3937e81
Compare
whoAbhishekSah
approved these changes
Apr 20, 2022
pkg/rules/service.go
Outdated
| repository: NewRepository(db), | ||
| templateService: templates.NewService(templateRepository), | ||
| repository: repository, | ||
| templateService: templates.NewService(templateRepository), |
There was a problem hiding this comment.
Let's just change this with templateService.
pkg/rules/service.go
Outdated
| } | ||
|
|
||
| if err := s.postRuleGroupWith(ctx, rule, rulesWithinGroup, client, namespace.Urn); err != nil { | ||
| fmt.Printf("err: %v\n", err) |
There was a problem hiding this comment.
let's remove this print statement
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* refactor(rule): change repository to accept and return domain and pass param as reference * refactor(rule): move repository into store * refactor(rule): move upsert business logic from repository to service * refactor(rule): build select query using gorm's builder * test(rule): fix tests after refactor * chore(rule): remove unnecessary log * chore(rule): replace ListByGroup with Get * chore(rule): change NewService param to accept template service instead of template repository * test(rule): add test cases for rollbacks returing error
ravisuhag
pushed a commit
that referenced
this pull request
Aug 21, 2022
* refactor(rule): change repository to accept and return domain and pass param as reference * refactor(rule): move repository into store * refactor(rule): move upsert business logic from repository to service * refactor(rule): build select query using gorm's builder * test(rule): fix tests after refactor * chore(rule): remove unnecessary log * chore(rule): replace ListByGroup with Get * chore(rule): change NewService param to accept template service instead of template repository * test(rule): add test cases for rollbacks returing error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.