Linked list conformance to collection protocol #583
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelvinlauKL
reviewed
Sep 29, 2017
There was a problem hiding this comment.
I apologize for the long turnaround for this one. Great work!
I like having the tag as part of your custom index. Works well. I've left a comment in regards to the explicit getters you've written for the computed properties.
Looking forward to merging this in!
| /// If the collection is empty, `startIndex` is equal to `endIndex`. | ||
| /// - Complexity: O(1) | ||
| public var startIndex: Index { | ||
| get { |
There was a problem hiding this comment.
The getter is implicit for all computed properties. No need to explicitly write get.
Merged
kelvinlauKL
approved these changes
Nov 30, 2017
|
@kelvinlauKL are you going to merge this? Is this complete? |
|
Sorry, this fell off my radar. Merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Adds conformance to the standard library's Collection protocol for the LinkedList class.