feat: merkle verification and changes implemented #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for razor-bridge-mainnet canceled.
|
yohanelly95
requested changes
Dec 18, 2023
SamAg19
requested review from
hrishikeshio,
SkandaBhat,
yohanelly95 and
rajkharvar
yohanelly95
reviewed
Dec 18, 2023
yohanelly95
previously approved these changes
Dec 18, 2023
rajkharvar
reviewed
Dec 18, 2023
yohanelly95
approved these changes
Dec 19, 2023
rajkharvar
approved these changes
Dec 19, 2023
| bytes memory signature | ||
| ) external onlyRole(FORWARDER_ROLE) returns (uint256, int8, uint256) { | ||
| if (result.lastUpdatedTimestamp > _collectionResults[result.name].lastUpdatedTimestamp) { | ||
| bytes memory resultBytes = abi.encode(result); |
| if (result.lastUpdatedTimestamp > _collectionResults[result.name].lastUpdatedTimestamp) { | ||
| bytes memory resultBytes = abi.encode(result); | ||
| bytes32 messageHash = keccak256( | ||
| abi.encodePacked(merkleRoot, resultBytes) |
| ) != signerAddress) revert InvalidSignature(); | ||
|
|
||
| bytes32 leaf = keccak256( | ||
| bytes.concat(keccak256(abi.encode(resultBytes))) |
| emit ResultUpdated(result); | ||
| } | ||
|
|
||
| return _getResult(result.name); |
There was a problem hiding this comment.
In future optimization, add multiproof support.
|
|
||
| emit BlockReceived(messageBlock); | ||
| return true; |
| @@ -3,80 +3,31 @@ pragma solidity ^0.8.0; | |||
|
|
|||
| interface IDelegator { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem statement:
The current implementation requires the signed Oracle block to be sent to the result manager to update collection values. This is not scalable and updating will become expensive as we add more collections to the Razor Oracle.
Solution:
We will be shifting to a Merkle tree implementation for updation in which the Merkle leaves will hold the result of each collection and the clients will receive signed result, Merkle root, and Merkle proof along with the signature for each collection depending on the collection data they require
To update the values of each collection, clients will need to query the Merkle tree for each collection off-chain which will be exposed through an API, and send the data received through their contracts to update the values. The clients will only need to update the collections they require for their application.
The functions exposed to clients will be:
fetchResult():- this function is responsible for updating the collection data and receiving the latest collection result. The result will only be updated if thelastUpdatedTimestampfor a particular collection in the contracts precedes the one that is being sent over, else the result won't be updated and the client will receive the stored result in the contractsgetResult():- this is a view function where you will just receive the collection data stored in the contracts. It does not deal with updation and the results retrieved may be stalevalidateResult(): this is a view function that allows people to validate whether the data they are receiving from the API is valid or not