Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionList): add ActionListItemAvatar component for leading prop #2341

Merged
merged 5 commits into from
Aug 29, 2024

Conversation

saurabhdaware
Copy link
Member

@saurabhdaware saurabhdaware commented Aug 28, 2024

Description

Support for Avatar in ActionListItem leading

Changes

Additional Information

Component Checklist

  • Update Component Status Page
  • Perform Manual Testing in Other Browsers
  • Add KitchenSink Story
  • Add Interaction Tests (if applicable)
  • Add changeset

Copy link

changeset-bot bot commented Aug 28, 2024

🦋 Changeset detected

Latest commit: fdeec1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@razorpay/blade Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 28, 2024

✅ PR title follows Conventional Commits specification.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fdeec1e:

Sandbox Source
razorpay/blade: basic Configuration

@rzpcibot
Copy link
Collaborator

Bundle Size Report

Updated Components
Status Component Base Size (kb) Current Size (kb) Diff
Accordion, AccordionItemHeader, AccordionItemBody, AccordionItem 7.462 7.464 +0.002 KB
ActionList, ActionListItem, ActionListItemAvatar, ActionListItemBadge, ActionListItemBadgeGroup, ActionListItemIcon, ActionListItemText, ActionListSection 0.000 16.062 +16.062 KB
Amount 1.123 1.125 +0.002 KB
Avatar, AvatarGroup, TrustedBadgeIcon 6.280 6.283 +0.003 KB
Badge 0.788 0.789 +0.001 KB
useBaseMenuItem -0.046 -0.045 +0.001 KB
BladeProvider 1.707 1.706 -0.001 KB
BottomSheet 9.409 9.410 +0.001 KB
Box 0.773 0.774 +0.001 KB
Breadcrumb, BreadcrumbItem 2.496 2.497 +0.001 KB
ButtonGroup 1.112 1.113 +0.001 KB
Card, CardBody, CardHeader, CardHeaderIcon, CardHeaderIconButton, CardHeaderLeading, CardHeaderTrailing, CardFooter, CardFooterLeading, CardFooterTrailing 9.199 9.201 +0.002 KB
Carousel, CarouselItem 6.815 6.817 +0.002 KB
Checkbox 5.948 5.953 +0.005 KB
Chip, ChipGroup 7.589 7.590 +0.001 KB
Collapsible, CollapsibleLink, CollapsibleButton, CollapsibleBody 9.664 9.665 +0.001 KB
Counter 0.753 0.754 +0.001 KB
DatePicker 85.255 85.256 +0.001 KB
Divider 0.521 0.522 +0.001 KB
Drawer, DrawerBody, DrawerHeader, drawerPadding 16.734 16.739 +0.005 KB
Dropdown, DropdownOverlay, DropdownButton, DropdownLink, DropdownFooter, DropdownHeader 27.998 28.002 +0.004 KB
List, ListItem, ListItemLink, ListItemCode, ListItemText 5.096 5.098 +0.002 KB
Menu, MenuItem, MenuOverlay, MenuDivider, MenuFooter, MenuHeader 28.815 28.819 +0.004 KB
Modal 13.109 13.113 +0.004 KB
Popover, PopoverInteractiveWrapper 20.847 20.851 +0.004 KB
Radio 4.754 4.757 +0.003 KB
SideNav, SideNavLink, SideNavLevel, SideNavSection, SideNavItem, SideNavFooter, SideNavBody, SIDE_NAV_EXPANDED_L1_WIDTH_BASE, SIDE_NAV_EXPANDED_L1_WIDTH_XL 32.309 32.314 +0.005 KB
Skeleton 0.746 0.745 -0.001 KB
SpotlightPopoverTour, SpotlightPopoverTourFooter, SpotlightPopoverTourStep 29.318 29.322 +0.004 KB
StepGroup, StepItem, StepItemIcon, StepItemIndicator 6.737 6.738 +0.001 KB
Switch 4.486 4.490 +0.004 KB
Table, TableHeader, TableHeaderCell, TableHeaderRow, TableBody, TableCell, TableRow, TableFooter, TableFooterCell, TableFooterRow, TablePagination, TableToolbar, TableToolbarActions, TableEditableCell, TableEditableDropdownCell 64.720 64.724 +0.004 KB
Tabs, TabItem, TabList, TabPanel 7.002 7.003 +0.001 KB
Tag 3.446 3.447 +0.001 KB
ToastContainer, useToast 12.503 12.507 +0.004 KB
Tooltip, TooltipInteractiveWrapper 15.775 15.778 +0.003 KB
TopNav, TopNavActions, TopNavBrand, TopNavContent 4.090 4.092 +0.002 KB
Button 5.984 5.985 +0.001 KB
IconButton 0.773 0.774 +0.001 KB
SelectInput, AutoComplete 35.767 35.770 +0.003 KB
OTPInput 29.918 29.923 +0.005 KB
PasswordInput 31.470 31.475 +0.005 KB
PhoneNumberInput 59.547 59.548 +0.001 KB
SearchInput 34.130 34.134 +0.004 KB
TextArea 31.833 31.837 +0.004 KB
TextInput 33.429 33.434 +0.005 KB
Link 2.114 2.115 +0.001 KB
RadioGroup 4.080 4.082 +0.002 KB
Spinner 1.794 1.795 +0.001 KB
TabNav, TabNavItem 9.128 9.130 +0.002 KB
Code 0.590 0.591 +0.001 KB
Text 0.002 0.003 +0.001 KB

Generated by 🚫 dangerJS against fdeec1e

@@ -210,6 +212,14 @@ const ActionListItemBadgeGroup = assignWithoutSideEffects(_ActionListItemBadgeGr
componentId: componentIds.ActionListItemBadgeGroup,
});

const _ActionListItemAvatar = (avatarProps: Omit<AvatarProps, 'size' | ''>): React.ReactElement => {
return <Avatar size="xsmall" {...avatarProps} />;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consumer cannot change size?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup checked with RK. size is always same

@saurabhdaware saurabhdaware merged commit eaa75c6 into master Aug 29, 2024
15 checks passed
@saurabhdaware saurabhdaware deleted the feat/avatar-actionlist branch August 29, 2024 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants