Skip to content
This repository has been archived by the owner on Nov 14, 2023. It is now read-only.

[OBSV-711] feat: add orderBy to Explorer visualisation #49

Merged
merged 8 commits into from
Jul 18, 2022
Merged

Conversation

cseas
Copy link
Member

@cseas cseas commented Jul 4, 2022

Description

https://razorpay.atlassian.net/browse/OBSV-711

Testing

Test Environment

  • orderBy field is added to GraphQL request with correct parameters when order is changed from UI
  • Ascending is default sorting (None), Descending sorting shows highest values

Checklist

  • My changes generate no new warnings

Screenshots

Screenshot 2022-07-08 at 10 28 03 PM

Misc

The type change in group-by component is done since console log shows the attribute is null initially on page load:

Screenshot 2022-07-11 at 3 50 01 PM

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@cseas cseas requested a review from akashmane1598 July 11, 2022 10:00
@github-actions

This comment has been minimized.

@github-actions
Copy link

Unit Test Results

       4 files     290 suites   20m 24s ⏱️
1 049 tests 1 049 ✔️ 0 💤 0 ❌
1 057 runs  1 057 ✔️ 0 💤 0 ❌

Results for commit 8c6a257.

Copy link

@akashmane1598 akashmane1598 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants