Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support options for reducing page faults #3

Closed
FlorianUekermann opened this issue Jul 18, 2020 · 3 comments
Closed

Support options for reducing page faults #3

FlorianUekermann opened this issue Jul 18, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@FlorianUekermann
Copy link

Having some options to reduce page faults would be great. On linux the MAP_HUGETLB and MAP_POPULATE options would be the most interesting imo.

@RazrFalcon
Copy link
Owner

Patches are welcome.

@RazrFalcon RazrFalcon added the help wanted Extra attention is needed label Dec 19, 2020
@adamreichold
Copy link

@RazrFalcon Concerning patches and the cross-platform target of this crate, would it be alright in your opinion to add an option like readahead to MmapOptions that maps to MAP_POPULATE on Linux but is a no-op on Windows? Or would you prefer a more complex implementation based on posix_madvise for better portability on non-Linux Unix platforms?

(Large pages seem to be available on both platforms even though the Windows variants seems to required more privileges.)

@RazrFalcon
Copy link
Owner

Yes, I think we could use no-op on Windows. MmapOptions::stack() already does this. Just note this in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants