Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: this PR is on top of #15, for convenience reasons (so i can build it :-))
this PR adds a build-target that creates a "libo2.so" file (a shared dynamic library).
more importantly, it adds code to hide symbols from the final binary, in order to not accidentally make private symbols available to host applications. (this was triggered because some private symbols disappeared between
1.0
and1.1
)now i don't know, whether you - as upstream - support shared libraries at all. however, for the Debian package we would very much like to build a shared library, to avoid code duplication (and be able to fix issues only once).
i have therefore split the commits into those that allow control of visibility (87164a1) and those that enable the building of a shared library (920950d, with e47dd5e).
so if you don't want to support shared libraries upstream, i would be thankful if you could at least accept 87164a1 into the codebase. as it would make life as Debian packages easier.
but of course, i would prefer if you properly supported shared libs :-)