-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check math and PGM diagrams are correct and consistent #10
Comments
…for the hyper-parameters. rbiswas4#10
OK, I have made some progress, in the master branch of my fork. I got halfway through @rbiswas4 's math, made some tweaks to try and explain what I think it meant in terms of the PGMs, and then also made a couple new PGMs. I suggest we pass this to @jmeyers314 for his comments, and perhaps some more math on the equations implied by these PGMs. Anyway, for your amusement, here are my new PGMs: |
I might come down to stanford or slac tomorrow. Will any of you be around?
|
Yep, I'll be here - I expect @kponder and @jmeyers314 will be as well. Its KIPAC tea at 10:30am, you should aim to be here for 10am coffee! Great stuff, looking fwd to seeing you. |
@kbarbary That would be great. I'll be around all day. |
Should we hold off on merging your master branch, @drphilmarshall? At first glance looks fine but I haven't looked over the math closely. The |
Yeah, let's write out the importance sampling concept and formula in such a On Fri, Mar 20, 2015 at 6:08 PM, Kyle Barbary notifications@github.com
|
Here's my attempt for including calibration, based off of Figure 1 from March++11 here: http://arxiv.org/pdf/1102.3237v4.pdf I followed the example in this paper and included a number of deterministic relationships that, though not strictly needed since they integrate out trivially, I think help to better illustrate the relationships between variables. Note that deterministic conditional PDFs (i.e., delta functions) are indicated with orange arrows, and probabilistic ones indicated in blue. The plates (boxes) separate variables that are indexed by SN i, band j, and epoch k. I left this a bit sloppy: e.g., if the 4th SN isn't observed in the 2nd epoch of the 6th band, then that entry in the likelihood function should just be 1. I think this also illustrates why importance sampling is so hard for the calibration variables: they form a deterministic relationship with the variables in the interim samples, which means that when you're reweighting the samples in the outer loop of importance sampling, the weight is a ratio of delta functions with (generally) non-overlapping support. I'll happily code this PGM up in daft, but I'll wait to hear if I made any errors first. Thanks! |
In standard PGM style the circles with all orange arrows pointing at them We realized today that in the March work, the SALT outputs re assumed to be An even more interesting generalization would be to replace all of March's I still think its worth trying to marginalize the calibration uncertainty On Monday, March 23, 2015, Josh Meyers notifications@github.com wrote:
|
For completeness! Let's assign this to @drphilmarshall :-)
The text was updated successfully, but these errors were encountered: