remove kodi-platform and add p8-platform to addon itself as depends #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There it is done with TinyXML2 and no need to use kodi-platform with TinyXML (old).
This is intended to significantly speed up the construction times for those who do not use these dependencies (most addons without this). This will also happen to all other PVRs that need it and also allows you to add your own versions if necessary. After converting this will be removed from Kodi. Only used on the Matrix branches, the others remain with Kodi.
|
Thanks a lot! |
|
Well, thanks go to you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to significantly speed up the construction times for those who do not use these dependencies (most addons without this).
This will also happen to all other PVRs that need it and also allows you to add your own versions if necessary.
After converting this will be removed from Kodi.
Only used on the Matrix branches, the others remain with Kodi.
Is related to this request xbmc/xbmc#17307, before this can be added, all addons must have inserted byself. Bring no problems if addon has this too, it will override that of Kodi.
Seen also you has included kodi-platform but seems no more needed and his work done by TinyXML2, his depend becomes on first commit removed.