Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qsub 1.1.0 #17

Merged
merged 60 commits into from
Feb 13, 2019
Merged

qsub 1.1.0 #17

merged 60 commits into from
Feb 13, 2019

Conversation

rcannood
Copy link
Owner

@rcannood rcannood commented Feb 13, 2019

qsub 1.1.0 has been submitted to CRAN.

Changes:

  • MINOR CHANGE: There is now an option to compress the output files, which is turned
    on by default.

  • MINOR CHANGE: Allow unix systems to use rsync instead of cp for fetching the qsub output.

  • BUG FIX: Fix qsub_retrieve() when processing the output; it did not take into account that
    batch_tasks could not be equal to 1.

  • MINOR CHANGE: qsub_retrieve() now uses pbapply when loading in the output.

  • BUG FIX: Test ssh connection pointer before using it.

  • BUG FIX: Do not remove the first line of an error file.

  • MINOR CHANGE: Use absolute paths to output standard output and error logs (Error and output log paths cause scripts to fail #16, suggested by @mmehan).

  • MINOR CHANGE; Allow rsync to also use the username@host:port notation (Error and output log paths cause scripts to fail #16, suggested by @mmehan).

zouter and others added 30 commits July 5, 2018 15:43
Merge branch 'devel' of github.com:rcannood/qsub into devel

# Conflicts:
#	R/ssh.R
@codecov-io
Copy link

codecov-io commented Feb 13, 2019

Codecov Report

Merging #17 into master will increase coverage by 5.38%.
The diff coverage is 67.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
+ Coverage   62.33%   67.71%   +5.38%     
==========================================
  Files           5        7       +2     
  Lines         446      508      +62     
==========================================
+ Hits          278      344      +66     
+ Misses        168      164       -4
Impacted Files Coverage Δ
R/qsub_config.R 91.52% <ø> (-0.15%) ⬇️
R/qstat_j.R 0% <0%> (ø) ⬆️
R/qacct.R 0% <0%> (ø) ⬆️
R/fetch_hostname_from_config.R 38.09% <38.09%> (ø)
R/qsub_run.R 84.18% <70.73%> (-0.67%) ⬇️
R/ssh.R 60.37% <74.28%> (+21.09%) ⬆️
R/read_ssh_config.R 83.33% <83.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b24d4a5...67707d9. Read the comment docs.

@rcannood
Copy link
Owner Author

On its way to CRAN

@rcannood rcannood merged commit d56a262 into master Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants