Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Set float highlight #166

Closed
elagil opened this issue Nov 6, 2022 · 1 comment
Closed

Question: Set float highlight #166

elagil opened this issue Nov 6, 2022 · 1 comment

Comments

@elagil
Copy link

elagil commented Nov 6, 2022

My goal is to set the float highlights in some way, for when I call eval().

Currently, it looks to me like a new float uses the Normal highlight group - always. Am I misreading this?

vim.fn.setwinvar(output_win_id, "&winhl", "Normal:Normal,FloatBorder:DapUIFloatBorder")

I wasn't able to tune the appearance of the float by adjusting the NormalFloat highlight group (which works for other cases, like nvim-cmp floats). How about introducing a new highlight group DapUINormalFloat, or using the NormalFloat group directly, so that the float background/text can be adjusted independently from the Normal group?

The default setting for a potential new DapUINormalFloat could be to link it to the Normal group, thus not changing the current behaviour.

rcarriga added a commit that referenced this issue Nov 8, 2022
@rcarriga
Copy link
Owner

rcarriga commented Nov 8, 2022

Makes total sense, I've linked to NormalFloat since that's what should be expected, using Normal was purely just because it worked my colorscheme 😅

@elagil elagil closed this as completed Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants