Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(README): improve suggested listener setup #313

Merged
merged 1 commit into from
Jan 4, 2024
Merged

docs(README): improve suggested listener setup #313

merged 1 commit into from
Jan 4, 2024

Conversation

Reisz
Copy link
Contributor

@Reisz Reisz commented Dec 29, 2023

The event_initialized used previously will sometimes fire despite debugging not being able to start.

For me this is reproducible by pressing ESC on the prompt for a debugee binary path with codelldb.

@rcarriga
Copy link
Owner

rcarriga commented Jan 3, 2024

Thanks for the PR! The wrapper functions were used because there are arguments passed to the listeners which are not intended for the open/close functions. Please add the wrapper functions back then LGTM 😄

The event_initialized used previously will sometimes fire despite debugging not being able to start.
@rcarriga rcarriga merged commit 7e5e164 into rcarriga:master Jan 4, 2024
serranomorante added a commit to serranomorante/.dotfiles that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants