webdav: make pacer minSleep configurable #6897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the config argument --webdav-pacer-min-sleep which specifies the http-request rate limit. Lowering this from the default 10ms can greatly improve performance when synchronizing small files. See: https://forum.rclone.org/t/webdav-with-persistent-connections/37024/10
9001
commented
Mar 26, 2023
| @@ -43,7 +43,7 @@ import ( | |||
| ) | |||
|
|
|||
| const ( | |||
| minSleep = 10 * time.Millisecond | |||
| minSleep = fs.Duration(10 * time.Millisecond) | |||
There was a problem hiding this comment.
This change ensures the setting is given the correct data type, as otherwise it wouldn't permit specifying the value using an ms suffix for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change?
This adds the config argument
--webdav-pacer-min-sleepwhich specifies the http-request rate limit, keeping the previous default of 10ms. Reducing this value can be very beneficial when synchronizing small files.Was the change discussed in an issue or in the forum before?
Yes; https://forum.rclone.org/t/webdav-with-persistent-connections/37024/10
Checklist
the autogenerated documentation seems to cover this change appropriattely, and I believe the change is trivial enough that it doesn't need any additional tests :>