Update server index.js and public index.html

Author: rcourtman

server/index.js

@@ -6,6 +6,9 @@ const stateManager = require('./state');
 // Import metrics history system
 const metricsHistory = require('./metricsHistory');
 
+// Import diagnostic tool
+const DiagnosticTool = require('./diagnostics');
+
 // --- BEGIN Configuration Loading using configLoader --- 
 const { loadConfiguration, ConfigurationError } = require('./configLoader');
 
@@ -405,6 +408,159 @@ app.get('/api/charts', async (req, res) => {
     }
 });
 
+// Simple diagnostic endpoint for troubleshooting
+app.get('/api/diagnostics-simple', async (req, res) => {
+    try {
+        // Delete from require cache to force reload
+        delete require.cache[require.resolve('./diagnostics-simple')];
+        const SimpleDiagnosticTool = require('./diagnostics-simple');
+        const tool = new SimpleDiagnosticTool(stateManager, apiClients, pbsApiClients);
+        const report = await tool.runDiagnostics();
+        res.json(report);
+    } catch (error) {
+        console.error("Simple diagnostics error:", error);
+        res.status(500).json({ error: error.message });
+    }
+});
+
+// Direct state inspection endpoint
+app.get('/api/diagnostics-state', (req, res) => {
+    try {
+        const state = stateManager.getState();
+        const summary = {
+            timestamp: new Date().toISOString(),
+            last_update: state.lastUpdate,
+            update_age_seconds: state.lastUpdate ? Math.floor((Date.now() - new Date(state.lastUpdate).getTime()) / 1000) : null,
+            guests_count: state.guests?.length || 0,
+            nodes_count: state.nodes?.length || 0,
+            pbs_count: state.pbs?.length || 0,
+            sample_guests: state.guests?.slice(0, 5).map(g => ({
+                vmid: g.vmid,
+                name: g.name,
+                type: g.type,
+                status: g.status
+            })) || [],
+            sample_backups: [],
+            errors: state.errors || []
+        };
+        
+        // Get sample backups
+        if (state.pbs && Array.isArray(state.pbs)) {
+            state.pbs.forEach(pbsInstance => {
+                if (pbsInstance.datastores) {
+                    pbsInstance.datastores.forEach(ds => {
+                        if (ds.snapshots && ds.snapshots.length > 0) {
+                            ds.snapshots.slice(0, 5).forEach(snap => {
+                                summary.sample_backups.push({
+                                    store: ds.store,
+                                    backup_id: snap['backup-id'],
+                                    backup_type: snap['backup-type'],
+                                    backup_time: new Date(snap['backup-time'] * 1000).toISOString()
+                                });
+                            });
+                        }
+                    });
+                }
+            });
+        }
+        
+        res.json(summary);
+    } catch (error) {
+        console.error("State inspection error:", error);
+        res.status(500).json({ error: error.message });
+    }
+});
+
+// Quick diagnostic check endpoint
+app.get('/api/diagnostics/check', async (req, res) => {
+    try {
+        // Use cached result if available and recent
+        const cacheKey = 'diagnosticCheck';
+        const cached = global.diagnosticCache?.[cacheKey];
+        if (cached && (Date.now() - cached.timestamp) < 60000) { // Cache for 1 minute
+            return res.json(cached.result);
+        }
+
+        // Run a quick check
+        delete require.cache[require.resolve('./diagnostics-fixed')];
+        const DiagnosticToolFixed = require('./diagnostics-fixed');
+        const diagnosticTool = new DiagnosticToolFixed(stateManager, metricsHistory, apiClients, pbsApiClients);
+        const report = await diagnosticTool.runDiagnostics();
+        
+        const hasIssues = report.recommendations && 
+            report.recommendations.some(r => r.severity === 'critical' || r.severity === 'warning');
+        
+        const result = {
+            hasIssues,
+            criticalCount: report.recommendations?.filter(r => r.severity === 'critical').length || 0,
+            warningCount: report.recommendations?.filter(r => r.severity === 'warning').length || 0
+        };
+        
+        // Cache the result
+        if (!global.diagnosticCache) global.diagnosticCache = {};
+        global.diagnosticCache[cacheKey] = { timestamp: Date.now(), result };
+        
+        res.json(result);
+    } catch (error) {
+        console.error("Error in diagnostic check:", error);
+        res.json({ hasIssues: false }); // Don't show icon on error
+    }
+});
+
+// Raw state endpoint - shows everything
+app.get('/api/raw-state', (req, res) => {
+    const state = stateManager.getState();
+    const rawState = stateManager.state || {};
+    res.json({
+        lastUpdate: state.lastUpdate,
+        statsLastUpdated: state.stats?.lastUpdated,
+        rawStateLastUpdated: rawState.stats?.lastUpdated,
+        guestsLength: state.guests?.length,
+        rawGuestsLength: rawState.guests?.length,
+        guestsType: Array.isArray(state.guests) ? 'array' : typeof state.guests,
+        allKeys: Object.keys(state),
+        rawKeys: Object.keys(rawState),
+        serverUptime: process.uptime(),
+        // Sample guest to see structure
+        firstGuest: state.guests?.[0],
+        rawFirstGuest: rawState.guests?.[0]
+    });
+});
+
+// --- Diagnostic Endpoint ---
+app.get('/api/diagnostics', async (req, res) => {
+    try {
+        console.log('Running diagnostics...');
+        // Force reload the diagnostic module to get latest changes
+        delete require.cache[require.resolve('./diagnostics-fixed')];
+        const DiagnosticToolFixed = require('./diagnostics-fixed');
+        const diagnosticTool = new DiagnosticToolFixed(stateManager, metricsHistory, apiClients, pbsApiClients);
+        const report = await diagnosticTool.runDiagnostics();
+        
+        // Format the report for easy reading
+        const formattedReport = {
+            ...report,
+            summary: {
+                hasIssues: report.recommendations && report.recommendations.some(r => r.severity === 'critical'),
+                criticalIssues: report.recommendations ? report.recommendations.filter(r => r.severity === 'critical').length : 0,
+                warnings: report.recommendations ? report.recommendations.filter(r => r.severity === 'warning').length : 0,
+                info: report.recommendations ? report.recommendations.filter(r => r.severity === 'info').length : 0,
+                isTimingIssue: report.state && report.state.dataAge === null && report.state.serverUptime < 90
+            }
+        };
+        
+        res.json(formattedReport);
+    } catch (error) {
+        console.error("Error running diagnostics:", error);
+        console.error("Stack trace:", error.stack);
+        res.status(500).json({ 
+            error: "Failed to run diagnostics", 
+            details: error.message,
+            stack: error.stack
+        });
+    }
+});
+
 // --- WebSocket Setup ---
 const io = new Server(server, {
   // Optional: Configure CORS for Socket.IO if needed, separate from Express CORS

src/public/index.html

@@ -188,6 +188,12 @@
           <span class="text-lg font-medium text-gray-800 dark:text-gray-200">Pulse</span>
         </div>
       <div class="header-controls flex justify-end items-center gap-4 md:flex-1">
+        <a id="diagnostics-icon" href="/diagnostics.html" target="_blank" class="hidden p-1 rounded-md text-gray-700 dark:text-gray-300 hover:bg-gray-200 dark:hover:bg-gray-700 focus:outline-none relative" title="Run Diagnostics" aria-label="Run diagnostics">
+          <svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
+            <path stroke-linecap="round" stroke-linejoin="round" d="M9.75 17L9 20l-1 1h8l-1-1-.75-3M3 13h18M5 17h14a2 2 0 002-2V5a2 2 0 00-2-2H5a2 2 0 00-2 2v10a2 2 0 002 2z" />
+          </svg>
+          <span id="diagnostics-badge" class="absolute -top-1 -right-1 h-2 w-2 bg-red-500 rounded-full hidden animate-pulse"></span>
+        </a>
         <button id="theme-toggle-button" type="button" class="p-1 rounded-md text-gray-700 dark:text-gray-300 hover:bg-gray-200 dark:hover:bg-gray-700 focus:outline-none" aria-label="Toggle theme">
           <svg xmlns="http://www.w3.org/2000/svg" class="h-5 w-5 block dark:hidden" fill="none" viewBox="0 0 24 24" stroke="currentColor" stroke-width="2">
             <path stroke-linecap="round" stroke-linejoin="round" d="M12 3v1m0 16v1m9-9h-1M4 12H3m15.364 6.364l-.707-.707M6.343 6.343l-.707-.707m12.728 0l-.707.707M6.343 17.657l-.707.707M16 12a4 4 0 11-8 0 4 4 0 018 0z" />
@@ -533,6 +539,64 @@
   <script>window.PulseApp = {};</script>
   <!-- <script src="/app.js" defer></script> -->
   <script src="/js/config.js" defer></script>
+  <script>
+    // Diagnostic icon visibility checker
+    (function() {
+      const checkDiagnostics = async () => {
+        try {
+          const response = await fetch('/api/diagnostics/check');
+          if (response.ok) {
+            const data = await response.json();
+            const icon = document.getElementById('diagnostics-icon');
+            const badge = document.getElementById('diagnostics-badge');
+            
+            if (data.hasIssues) {
+              icon.classList.remove('hidden');
+              if (data.severity === 'error') {
+                badge.classList.remove('hidden');
+              } else {
+                badge.classList.add('hidden');
+              }
+              
+              // Update tooltip with issue count
+              if (data.issueCount) {
+                icon.title = `Run Diagnostics (${data.issueCount} issue${data.issueCount > 1 ? 's' : ''} detected)`;
+              }
+            } else {
+              icon.classList.add('hidden');
+            }
+          }
+        } catch (error) {
+          console.error('Failed to check diagnostics:', error);
+        }
+      };
+      
+      // Check immediately after DOM loads
+      if (document.readyState === 'loading') {
+        document.addEventListener('DOMContentLoaded', checkDiagnostics);
+      } else {
+        checkDiagnostics();
+      }
+      
+      // Check periodically
+      setInterval(checkDiagnostics, 300000); // Every 5 minutes
+      
+      // Also check when socket reconnects
+      if (window.io) {
+        const checkOnConnect = () => {
+          const socket = window.PulseApp?.socket;
+          if (socket) {
+            socket.on('connect', () => {
+              setTimeout(checkDiagnostics, 5000); // Check 5 seconds after connection
+            });
+          } else {
+            setTimeout(checkOnConnect, 100);
+          }
+        };
+        checkOnConnect();
+      }
+    })();
+  </script>
   <script src="/js/state.js" defer></script>
   <script src="/js/debounce.js" defer></script>
   <script src="/js/virtual-scroll.js" defer></script>