@@ -42,13 +42,13 @@ describe('AlertManager Webhook Functionality', () => {
4242 } ,
4343 guest : {
4444 name : 'test-vm' ,
45- id : '100' ,
45+ vmid : '100' ,
4646 type : 'qemu' ,
4747 node : 'test-node' ,
4848 status : 'running'
4949 } ,
50- value : 92 ,
51- threshold : 85 ,
50+ currentValue : 92 ,
51+ effectiveThreshold : 85 ,
5252 triggeredAt : 1640995200000 , // Valid timestamp
5353 lastUpdate : 1640995260000 // Valid timestamp
5454 } ;
@@ -72,14 +72,12 @@ describe('AlertManager Webhook Functionality', () => {
7272 expect ( mockAxios . post ) . toHaveBeenCalledTimes ( 1 ) ;
7373 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
7474
75- // Check main timestamp field
76- expect ( payload . timestamp ) . toBe ( new Date ( mockAlert . triggeredAt ) . toISOString ( ) ) ;
77-
78- // Check embed timestamp
79- expect ( payload . embeds [ 0 ] . timestamp ) . toBe ( new Date ( mockAlert . triggeredAt ) . toISOString ( ) ) ;
80-
81- // Check Slack timestamp (Unix timestamp)
75+ // For Slack webhooks, check the timestamp in attachments
8276 expect ( payload . attachments [ 0 ] . ts ) . toBe ( Math . floor ( mockAlert . triggeredAt / 1000 ) ) ;
77+
78+ // Slack webhooks don't have top-level timestamp or embeds
79+ expect ( payload . timestamp ) . toBeUndefined ( ) ;
80+ expect ( payload . embeds ) . toBeUndefined ( ) ;
8381 } ) ;
8482
8583 test ( 'should fallback to lastUpdate when triggeredAt is missing' , async ( ) => {
@@ -94,9 +92,7 @@ describe('AlertManager Webhook Functionality', () => {
9492 expect ( mockAxios . post ) . toHaveBeenCalledTimes ( 1 ) ;
9593 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
9694
97- // Should use lastUpdate timestamp
98- expect ( payload . timestamp ) . toBe ( new Date ( mockAlert . lastUpdate ) . toISOString ( ) ) ;
99- expect ( payload . embeds [ 0 ] . timestamp ) . toBe ( new Date ( mockAlert . lastUpdate ) . toISOString ( ) ) ;
95+ // Should use lastUpdate timestamp in Slack format
10096 expect ( payload . attachments [ 0 ] . ts ) . toBe ( Math . floor ( mockAlert . lastUpdate / 1000 ) ) ;
10197 } ) ;
10298
@@ -115,10 +111,11 @@ describe('AlertManager Webhook Functionality', () => {
115111 expect ( mockAxios . post ) . toHaveBeenCalledTimes ( 1 ) ;
116112 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
117113
118- // Should use current time (within reasonable range)
119- const timestamp = new Date ( payload . timestamp ) . getTime ( ) ;
120- expect ( timestamp ) . toBeGreaterThanOrEqual ( beforeTime ) ;
121- expect ( timestamp ) . toBeLessThanOrEqual ( afterTime ) ;
114+ // Should use current time (within reasonable range) for Slack format
115+ // Note: Unix timestamps lose millisecond precision, so allow for some tolerance
116+ const timestamp = payload . attachments [ 0 ] . ts * 1000 ; // Convert Unix timestamp back to milliseconds
117+ expect ( timestamp ) . toBeGreaterThanOrEqual ( Math . floor ( beforeTime / 1000 ) * 1000 ) ;
118+ expect ( timestamp ) . toBeLessThanOrEqual ( Math . ceil ( afterTime / 1000 ) * 1000 ) ;
122119 } ) ;
123120
124121 test ( 'should handle invalid timestamp values gracefully' , async ( ) => {
@@ -138,10 +135,11 @@ describe('AlertManager Webhook Functionality', () => {
138135 expect ( mockAxios . post ) . toHaveBeenCalledTimes ( 1 ) ;
139136 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
140137
141- // Should fallback to current time when timestamps are invalid
142- const timestamp = new Date ( payload . timestamp ) . getTime ( ) ;
143- expect ( timestamp ) . toBeGreaterThanOrEqual ( beforeTime ) ;
144- expect ( timestamp ) . toBeLessThanOrEqual ( afterTime ) ;
138+ // Should fallback to current time when timestamps are invalid (Slack format)
139+ // Note: Unix timestamps lose millisecond precision, so allow for some tolerance
140+ const timestamp = payload . attachments [ 0 ] . ts * 1000 ;
141+ expect ( timestamp ) . toBeGreaterThanOrEqual ( Math . floor ( beforeTime / 1000 ) * 1000 ) ;
142+ expect ( timestamp ) . toBeLessThanOrEqual ( Math . ceil ( afterTime / 1000 ) * 1000 ) ;
145143 } ) ;
146144 } ) ;
147145
@@ -154,26 +152,19 @@ describe('AlertManager Webhook Functionality', () => {
154152 expect ( mockAxios . post ) . toHaveBeenCalledTimes ( 1 ) ;
155153 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
156154
157- // Check main structure
158- expect ( payload ) . toHaveProperty ( 'timestamp' ) ;
159- expect ( payload ) . toHaveProperty ( 'alert' ) ;
160- expect ( payload ) . toHaveProperty ( 'embeds' ) ;
155+ // Check Slack webhook structure (based on URL)
161156 expect ( payload ) . toHaveProperty ( 'text' ) ;
162157 expect ( payload ) . toHaveProperty ( 'attachments' ) ;
163-
164- // Check Discord embed structure
165- expect ( payload . embeds ) . toHaveLength ( 1 ) ;
166- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'title' ) ;
167- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'description' ) ;
168- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'color' ) ;
169- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'fields' ) ;
170- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'footer' ) ;
171- expect ( payload . embeds [ 0 ] ) . toHaveProperty ( 'timestamp' ) ;
158+
159+ // Slack webhooks don't have these properties
160+ expect ( payload ) . not . toHaveProperty ( 'timestamp' ) ;
161+ expect ( payload ) . not . toHaveProperty ( 'alert' ) ;
162+ expect ( payload ) . not . toHaveProperty ( 'embeds' ) ;
172163
173164 // Check Slack attachment structure
174165 expect ( payload . attachments ) . toHaveLength ( 1 ) ;
175- expect ( payload . attachments [ 0 ] ) . toHaveProperty ( 'color' ) ;
176166 expect ( payload . attachments [ 0 ] ) . toHaveProperty ( 'fields' ) ;
167+ expect ( payload . attachments [ 0 ] ) . toHaveProperty ( 'color' ) ;
177168 expect ( payload . attachments [ 0 ] ) . toHaveProperty ( 'footer' ) ;
178169 expect ( payload . attachments [ 0 ] ) . toHaveProperty ( 'ts' ) ;
179170 } ) ;
@@ -185,38 +176,34 @@ describe('AlertManager Webhook Functionality', () => {
185176
186177 const payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
187178
188- // Check alert fields
189- expect ( payload . alert . id ) . toBe ( mockAlert . id ) ;
190- expect ( payload . alert . rule . name ) . toBe ( mockAlert . rule . name ) ;
191- expect ( payload . alert . rule . severity ) . toBe ( mockAlert . rule . severity ) ;
192- expect ( payload . alert . guest . name ) . toBe ( mockAlert . guest . name ) ;
193- expect ( payload . alert . value ) . toBe ( mockAlert . value ) ;
194- expect ( payload . alert . threshold ) . toBe ( mockAlert . threshold ) ;
179+ // Check Slack format fields (data is in text and attachments)
180+ expect ( payload . text ) . toContain ( mockAlert . rule . name ) ;
181+ expect ( payload . attachments [ 0 ] . fields [ 0 ] . value ) . toContain ( mockAlert . guest . name ) ;
182+ expect ( payload . attachments [ 0 ] . fields [ 1 ] . value ) . toBe ( mockAlert . guest . node ) ;
183+ expect ( payload . attachments [ 0 ] . fields [ 2 ] . value ) . toContain ( '92%' ) ; // formatted value
184+ expect ( payload . attachments [ 0 ] . fields [ 2 ] . value ) . toContain ( '85%' ) ; // formatted threshold
195185 } ) ;
196186
197187 test ( 'should set correct colors based on severity' , async ( ) => {
198188 mockAxios . post . mockResolvedValue ( { status : 200 , data : { success : true } } ) ;
199189
200- // Test warning severity
190+ // Test warning severity (Slack format only has attachments)
201191 await alertManager . sendWebhookNotification ( mockWebhookChannel , mockAlert ) ;
202192 let payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
203- expect ( payload . embeds [ 0 ] . color ) . toBe ( 15844367 ) ; // Orange
204193 expect ( payload . attachments [ 0 ] . color ) . toBe ( 'warning' ) ;
205194
206195 // Test critical severity
207196 mockAxios . post . mockClear ( ) ;
208197 const criticalAlert = { ...mockAlert , rule : { ...mockAlert . rule , severity : 'critical' } } ;
209198 await alertManager . sendWebhookNotification ( mockWebhookChannel , criticalAlert ) ;
210199 payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
211- expect ( payload . embeds [ 0 ] . color ) . toBe ( 15158332 ) ; // Red
212200 expect ( payload . attachments [ 0 ] . color ) . toBe ( 'danger' ) ;
213201
214202 // Test info severity
215203 mockAxios . post . mockClear ( ) ;
216204 const infoAlert = { ...mockAlert , rule : { ...mockAlert . rule , severity : 'info' } } ;
217205 await alertManager . sendWebhookNotification ( mockWebhookChannel , infoAlert ) ;
218206 payload = mockAxios . post . mock . calls [ 0 ] [ 1 ] ;
219- expect ( payload . embeds [ 0 ] . color ) . toBe ( 3447003 ) ; // Blue
220207 expect ( payload . attachments [ 0 ] . color ) . toBe ( 'good' ) ;
221208 } ) ;
222209 } ) ;
0 commit comments