-
Notifications
You must be signed in to change notification settings - Fork 493
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graphite DurationUnit has confusing semantics #74
Comments
I worked around this by compressing time in my calls to
Am I misunderstanding the point of |
Looks like a bug, thanks. |
pteichman
pushed a commit
to pteichman/go-metrics
that referenced
this issue
Oct 14, 2014
This fixes Timer reporting with DurationUnits other than the default time.Nanosecond. Fixes rcrowley#74
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm attempting to report timers to Graphite using millisecond units. With
DurationUnit: time.Nanosecond
(the default), they're off by a factor of a million. WithDurationUnit: time.Millisecond
, they're off by a trillion.Is this a problem of documentation (there aren't any DurationUnit examples) or should all the timer metrics be
t.Foo()/du
rather thandu*t.Foo()
? I'm happy to make the patch in either case.The text was updated successfully, but these errors were encountered: