-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Branch, or release without submodules #21
Comments
Not sure if I understand the request correctly but wouldn't it be enough for your other project to use Or some alternative ideas:
|
well when you have a project with lots of (10+) submodules, that becomes the easiest way... I don't know if it's worth catering to 'those projects', i'm just bringing it up because I had this problem.
https://cmake.org/cmake/help/latest/module/FetchContent.html |
For cmake features please also check if they need a more recent cmake version so that we change the requirements in CMakeLists accordingly (the FetchContent seems to require 3.11 or newer). For our usecases we don't really need to fetch the content via git but we could probably use the smaller ExternalProject option and just fetch a given version via its URL (any tagged commit has a stable URL for download in github). |
After looking into this, it seems overly complicated to remove the submodules. I sort of like how it is now, so let's just keep it this way :D |
If any program wants to include
mmtf-cpp
as a submodule they probably don't want to include all of our submodules too, as they're large, and take a long time to download.(Basically you cant use:
git submodule update --init --recursive
)we should think of a way to make a branch or release without the submodules. I think it should be possible with some travis-ci voodoo, but I don't know travis at all.
The text was updated successfully, but these errors were encountered: