Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5MOO has bonds between alt confs #44

Closed
speleo3 opened this issue Nov 8, 2019 · 7 comments
Closed

5MOO has bonds between alt confs #44

speleo3 opened this issue Nov 8, 2019 · 7 comments

Comments

@speleo3
Copy link
Contributor

speleo3 commented Nov 8, 2019

The MMTF file for 5MOO has bonds between alternate conformations of residue MET104 (for hydrogens which are only in one conformation). I don't see those bonds in the mmCIF file, so it looks like this is not a "primary-data-issue".

5moo-m104-extra-bonds

@arose
Copy link
Contributor

arose commented Nov 8, 2019

ping @josemduarte, is this an issue in biojava as well?

@josemduarte
Copy link
Member

Good catch, thanks @speleo3 ! I could track this back to an issue in BioJava. I will implement a fix that does not add bonds when alt locs are not the default '.' and are different (e.g. if atom 1 is 'A' and atom 2 is 'B').

There's in any case a certain ambiguity in alt loc definition. For instance what should happen when:

  • Case 1. Atom 1 alt locs : '.', 'A' and 'B', atom 2 alt locs: 'A' and 'B'. Should '.' be linked to both 'A' and 'B' or should it be linked to nothing?
  • Case 2. Atom 1 alt locs: '.', atom 2 alt locs: 'A' and 'B'. Should '.' be linked to both 'A' and 'B' or should it be linked to nothing?

@speleo3
Copy link
Contributor Author

speleo3 commented Nov 12, 2019

@josemduarte Does case 1 exist? Do you have an example?

Case 2 should always link both (., A) and (., B) for what I've seen so far. Do you have an example where that's wrong?

@speleo3
Copy link
Contributor Author

speleo3 commented Nov 12, 2019

5MOO MET104/N is an example for case 2 where MMTF is missing the bond from ILE103/C to MET104/N-B:

5moo-104-n

@josemduarte
Copy link
Member

Thanks @speleo3 . I don't have an example of case 1, perhaps it doesn't exist, was simply trying to look at all possible edge cases.

I've submitted a fix for BioJava. For both case 1 and 2 it will always link '.' to A and B.

In any case it will still be some time before the mmtf files are updated.

@josemduarte
Copy link
Member

The issue was fixed in BioJava 5.4.0. The mmtf update pipeline was also updated accordingly. All new mmtf files should have this fix. The old ones will have to be regenerated at some point.

@josemduarte
Copy link
Member

All files have been regenerated now. The issue should be gone from all files now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants