Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate sqlserver driver to use Microsoft.Data.SqlClient #224

Closed
rdagumampan opened this issue Jan 2, 2022 · 5 comments · Fixed by #267
Closed

Migrate sqlserver driver to use Microsoft.Data.SqlClient #224

rdagumampan opened this issue Jan 2, 2022 · 5 comments · Fixed by #267
Labels
help wanted You're welcome to work on it right away platform-sqlserver
Milestone

Comments

@rdagumampan
Copy link
Owner

Hi @farazfaheem, sorry for delayed response, been busy lately on python and databricks :). I have investigated this and it seems related to the SqlClient I used. The issue could be fixed if I use Microsoft.Data.SqlClient. It can also be fixed if I dont use the SqlClient.SqlConnectionStringBuilder.

I dont have a fixed yet but as work around for now would be to use Sql Account. Please stay tune, I will pickup all these open bugs during my summer holiday in Mid May :)

Originally posted by @rdagumampan in #199 (comment)

@rdagumampan rdagumampan added platform-sqlserver help wanted You're welcome to work on it right away labels Jan 2, 2022
@rdagumampan rdagumampan added this to the v1.3 milestone Jan 2, 2022
@smitvora10
Copy link

Can i help with this to solve this issue?

@rdagumampan
Copy link
Owner Author

@smitvora10, thank you first for reaching out and yes are of course very much welcome to contribute :).

Here's a few steps to get you started, see if you can build and run tests locally
https://github.com/rdagumampan/yuniql/wiki/Setup-development-environment

In case you missed it, please click the Start button and Fork to get clone. You can ask me questions here or in LinkedIn, I'll try to support you as much as I could possible do. Have a nice day // Rodel

@rdagumampan
Copy link
Owner Author

This issue is related to:
#229 Setup Azure AD support
#199 Failed connecting to Azure Sql Database
#223 Upgrade solution to .NET 6 LTS

@smitvora10
Copy link

smitvora10 commented Jan 12, 2022 via email

@pmelander
Copy link

pmelander commented May 7, 2022

I have a Fork where I upgraded to Microsoft.Data.SqlClient and it seems to be working pretty straight forward. I was not able to get the tests running because of a locale issue, but I've successfully deployed to an Azure SQL Server using Active Directory Default authentication, which is not supported in System.Data.SqlClient.

Also, i'm not sure how you get the Microsoft.Data.SqlClient.SNI.dll packaged inside the executable. I usually don't have to worry about such things. But at least it's a feasible upgrade.

[CmdletBinding(DefaultParameterSetName = 'None')]
param
(
  [String] [Parameter(Mandatory = $true)] $ServerName,
  [String] [Parameter(Mandatory = $true)] $Database
)

.\yuniql.exe run --connection-string "Server=tcp:$ServerName,1433;Database=$Database;Authentication=Active Directory Default" --auto-create-db --environment "DEV"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted You're welcome to work on it right away platform-sqlserver
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants