Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 223 Upgrade to .Net 6.0 LTS #266

Merged
merged 3 commits into from
May 2, 2022

Conversation

Jean-Paul76
Copy link
Contributor

Upgraded all projects to use .net 6 and updated all referenced assemblies to their latest versions.

I ran the SQL Server test, 9 of which failed.
Test Result

Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
  Failed Test_Run_Fail_Migration_When_Version_Directory_With_Explicit_Transaction_Has_Other_Directories
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Fail_Migration_When_Version_With_Explicit_Transaction_Directory_Has_Files
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Fail_Migration_When_DDL_Failed_And_Transactional_DDL_Not_Supported
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Fail_Migration_When_No_Force_Continue_After_Failue_Option_Enabled
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Ok_Migration_With_Force_Continue_After_Failue_Option_Enabled
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Ok_Without_Explicit_Transaction
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Ok_With_Explicit_Transaction
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Ok_Without_Explicit_Transaction_With_SubDirectories
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

  Failed Test_Run_Ok_With_Explicit_Transaction_With_SubDirectories
  Standard Output Messages:
 Target database platform or version does not support atomic DDL operations. DDL operations like CREATE TABLE, CREATE VIEW are not gauranteed to be executed transactional.

Upgrade project files to .Net 6.0.
Upgrade all referenced packages to their most recent versions.
@Jean-Paul76 Jean-Paul76 mentioned this pull request May 2, 2022
@rdagumampan
Copy link
Owner

@Jean-Paul76 , thanks for new PR with fix to git issues. I was able to build and reproduce those failed tests now. It seems that net6 sdk still consider these tests as failed even if it should be ignored. I will investigate further and let you know later today.

image

@rdagumampan
Copy link
Owner

I made small changes to fix the custom TestMethodEx attribute and tests have passed. I have not run tests for Snowflake and Redshift but I will run during release as I need to setup a new instance every time. I will push my changes to this PR and merge it. Thanks for excellent work. This has been major ticket I was hoping to sit down during Easter but I was not able to get the time :)

SQL Server

image

#### PostgresSql
Passed!  - Failed:     0, Passed:   202, Skipped:    16, Total:   218, Duration: 4 m 9 s - Yuniql.PlatformTests.dll (net6.0)
dc
#### MySql
Passed!  - Failed:     0, Passed:   192, Skipped:    26, Total:   218, Duration: 9 m 8 s - Yuniql.PlatformTests.dll (net6.0)

#### MariaDB
Passed!  - Failed:     0, Passed:   192, Skipped:    26, Total:   218, Duration: 6 m 45 s - Yuniql.PlatformTests.dll (net6.0)

#### Oracle
Passed!  - Failed:     0, Passed:   190, Skipped:    28, Total:   218, Duration: 13 m 38 s - Yuniql.PlatformTests.dll (net6.0)

@sonarcloud
Copy link

sonarcloud bot commented May 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Owner

@rdagumampan rdagumampan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Really appreciate your effort in lifting yuniql to .NET 6 LTS!

@rdagumampan rdagumampan merged commit 34599ac into rdagumampan:master May 2, 2022
@rdagumampan rdagumampan linked an issue May 2, 2022 that may be closed by this pull request
@rdagumampan rdagumampan added this to the v1.3 milestone May 2, 2022
@Jean-Paul76
Copy link
Contributor Author

Jean-Paul76 commented May 3, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade solution to use .NET 6 LTS version
2 participants