Link capi #998
Merged
Link capi #998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
rsetaluri
approved these changes
Apr 5, 2021
rdaly525
added a commit
that referenced
this pull request
Apr 21, 2021
* Fix CORENamedTypeToString c-API (#982) This change adds a context-managed scratch-pad memory which can be used safely, without risk of a memory leak. The c-API CORENamedTypeToString previously returned a pointer to a temporary, which is unsafe. Instead, we allocate context-managed memory and return a buffer contained there. See #969. * Update C-API for record to use deterministic order (#985) Possible fix for phanrahan/magma#920 (comment) Before, this was iterating over a std::map which is not ordered. This changes it to use the `getFields` API which should return the same order for the fields. * bumps version * Add compile guard support (#986) * Add compile guard support * Bump verilogast commit * Simplify test * Add support for verilog body string (#987) This was a feature we used to support in magma (see first example https://github.com/phanrahan/magmathon/blob/master/notebooks/advanced/verilog.ipynb) that used the verilog backend. This adds support for the same feature in the coreir backend. This simply allows the user to define circuit interface in magma/coreir, but the body in verilog. This is slightly different than inline verilog in that we allow the user to drive signals from the verilog body string. Otherwise, if we drove a signal from inline_verilog, we'd get an undriven error in magma/coreir since we aren't aware of the driver from the string. * Support user_namespace with verilog_body (#989) * Add support for inverted compile guard (#988) * Add support for inverted compile guard Support for the `ifndef` pattern has been requested. * use type=defined/undefined instead of invert * Clang format * [#990] Add compile option for verilog prefix (#991) * [#990] Add compile option for verilog prefix * Add binary interface * Add instance logic * Track only changed modules * Add complex test * Add missing files * Encapsulate addPrefix logic, include in writeToFiles flow * Adds support for outputs inside a compile guard (#992) By default, we drive outputs to be 0 inside the else clause (should work for arbitrary ports since types have been flattened). This allows for "stubs" to be inserted when a compile_guard is not active. This feature is simpler than supporting a general output handler in the compile guard, since then we'd need to support multiple drivers from different compile guard cases which is tricky since in magma/coreir we only allow a single driver for a port. This covers the use case at FB without having to dive into the details of general output handling. * Add option for verilog-prefix of extern modules (#993) * Add option for verilog-prefix of extern modules * passthrough arg * Update src/passes/analysis/verilog.cpp Co-authored-by: rsetaluri <rsetaluri@users.noreply.github.com> * Update src/passes/analysis/verilog.cpp Co-authored-by: rsetaluri <rsetaluri@users.noreply.github.com> * Fix metadata override case Co-authored-by: rsetaluri <rsetaluri@users.noreply.github.com> * Add symbol table shell/scaffolding (#984) * Add symbol table shell/scaffolding * Symbol table updates Adds debug option to pass manager (and coreir binary). Creates concrete implementation of symbol table API. Updates flattentypes pass to use symbol table API * Move symbol table impl into separate file * Add dummy implementation for CoreIRSymbolTable * Add json interface * Implement basic symbol table data structures * Implement jsonification routine * Update port name interface This change removes the output module name from the set/getPortName interface. * Write symbol table to file * Implement simple instance name mapping * Add inline instance API This change just adds the APIs and nec. data structures for keeping track of inlining. * Add TODO for addPrefix re: symbol tables * Fix Jsonifier template param Co-authored-by: Ross <rdaly525@stanford.edu> * bumps version * Link (#996) * Refactored json serialization code. added a serialization pass based off an instancegraph pass. Deprecated saveToFile. Added loadHeader API and linkImpl API. added a couple tests * fixes serialization format * adds headergen and implgen tests * impl generation now works * header gen tests work * fixes base path for linking test * un-deprecated saveToFile * FileReader fixes. Adds a unit test in gtest with the anytest and saveAndLoad * test fixes to prevent impl link error * renames impl to definition. renames some helper functions for clarification * clarifying comments * Instrument inline symbol table (#997) * Add back flattentypes test In a force push, commit 0e1b09e was lost. This commit adds it back. Original commit message: "adds basic symbol table test for flatten types" * Add simple inlineInstance test * Move set-up and tear-down to test fixture * Add inlineInstance symbol table test NOTE: This is just the test for inlining. It does not yet instrument the pass to update the symbol table. * Support multi-level inlining This commit adds support to the SymbolTableInterface API to allow for multi-level inlining. It does this by making the return type of get_inlined_instance_name() to be Union[str, Sentinel] (just like get_instance_name()). We also update the internal data structures to support storing this union, as well as ser/deser. NOTE: We still have not instrumented the inline pass. * Add instance type API Add API to allow for get/setting types of instances (a simple str -> str -> str function). * Update inlined instance API to take a vector of instances * Fix typo setInlineInstance -> setInlinedInstance * Update inline test for new API * Update simple hierarchy example * Update inline test for new hierarchy example * Revert inlinedInstance API change This change reverts the change to make the {set,get}inlinedInstance API take in a vector. We now take in a pair as before. * Add scaffolding for logging This change introduces logging APIs to the symbol table to allow for staged symbol table updates. TODO: Implement the logic for finalize() (merging logs) and pass the right arguments into the logging call from inlineInstance(). * Fix basic inline test * Make logger accesible directly from symbol table * Update logger interface * Log new instances in module def * Log inlined instances in inlineInstance() * Add debugging capabilities to logger * Skip logging new/removed passthrough instances * Fix debug iterator bug * Pause logging during extraneous actions in inlineInstances * Implement symbol table logging finalization * Set types during finalization * Fix compiler issues/warnings * Fix compiler issues/warnings * Put symbol table behind flag * Fix minor issues * bumps version * Link capi (#998) * adds serializer_header api * adds loadheader api * updates c api for link apis * bumps version * Skip symbol table logging for generators (#999) * Bump version (#1000) * Use module longmame for symbol table (#1001) Using a module's longname allows us to include generators and circuits across namespaces. * adds get function for instance metadata (#1002) * adds get function for instance metadata * Update src/coreir-c/coreir-c.cpp Co-authored-by: rsetaluri <rsetaluri@users.noreply.github.com> * bumps version * Multiplier variations in commonlib for returning middle and high bits (#1004) * Mult variations (#1005) * Multiplier variations in commonlib for returning middle and high bits * Fixes to multiply variations * Multiply variations; remove unintended comments * bumps version * demangles stack trace (#887) * Canon (#980) * adds verify_cannonical pass and starts canonicalize pass * Adds back API for CoreIRTypes as values * Adds python test for canonicalizing counters.json * Adds pack and unpack to coreir namespace * bug fix * adds reconnect convenience function * adds passes * Update wireable.h fixes comment * fixes * Adds canon src code * Code cleanup * Fixes unused var warnings with strucutred bindings * comment and code clarity fixes Co-authored-by: Raj Setaluri <raj.setaluri@gmail.com> * Add unused() function (#983) Co-authored-by: rsetaluri <rsetaluri@users.noreply.github.com> Co-authored-by: Leonard (Lenny) Truong <lenny@stanford.edu> Co-authored-by: Jeff Setter <setter@stanford.edu> Co-authored-by: Raj Setaluri <raj.setaluri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the link/load APIs as C APIs